mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Leszczynski <konrad.leszczynski@intel.com>
To: davem@davemloft.net, andrew+netdev@lunn.ch, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	cezary.rojewski@intel.com, sebastian.basierski@intel.com,
	Karol Jurczenia <karol.jurczenia@intel.com>,
	Konrad Leszczynski <konrad.leszczynski@intel.com>
Subject: [PATCH net 3/3] net: stmmac: check if interface is running before TC block setup
Date: Thu, 28 Aug 2025 12:02:37 +0200	[thread overview]
Message-ID: <20250828100237.4076570-4-konrad.leszczynski@intel.com> (raw)
In-Reply-To: <20250828100237.4076570-1-konrad.leszczynski@intel.com>

From: Karol Jurczenia <karol.jurczenia@intel.com>

If the interface is down before setting a TC block, the queues are already
disabled and setup cannot proceed.

Fixes: 4dbbe8dde8485b89 ("net: stmmac: Add support for U32 TC filter using Flexible RX Parser")
Reviewed-by: Sebastian Basierski <sebastian.basierski@intel.com>
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: Karol Jurczenia <karol.jurczenia@intel.com>
Signed-off-by: Konrad Leszczynski <konrad.leszczynski@intel.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 70c3dd88a749..202a157a1c90 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -6247,6 +6247,9 @@ static int stmmac_setup_tc_block_cb(enum tc_setup_type type, void *type_data,
 	struct stmmac_priv *priv = cb_priv;
 	int ret = -EOPNOTSUPP;
 
+	if (!netif_running(priv->dev))
+		return -EINVAL;
+
 	if (!tc_cls_can_offload_and_chain0(priv->dev, type_data))
 		return ret;
 
-- 
2.34.1


  parent reply	other threads:[~2025-08-28  9:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28 10:02 [PATCH net 0/3] net: stmmac: misc fixes Konrad Leszczynski
2025-08-28 10:02 ` [PATCH net 1/3] net: stmmac: replace memcpy with strscpy in ethtool Konrad Leszczynski
2025-08-28 13:29   ` Vadim Fedorenko
2025-09-01 19:59   ` Jakub Kicinski
2025-09-04 18:53     ` Sebastian Basierski
2025-09-04 19:18       ` Andrew Lunn
2025-09-15 13:18         ` Konrad Leszczynski
2025-08-28 10:02 ` [PATCH net 2/3] net: stmmac: correct Tx descriptors debugfs prints Konrad Leszczynski
2025-08-28 13:34   ` Vadim Fedorenko
2025-09-01 20:01   ` Jakub Kicinski
2025-09-04 18:54     ` Sebastian Basierski
2025-09-15 12:54       ` Konrad Leszczynski
2025-09-15 15:05         ` Jakub Kicinski
2025-08-28 10:02 ` Konrad Leszczynski [this message]
2025-08-28 13:39   ` [PATCH net 3/3] net: stmmac: check if interface is running before TC block setup Vadim Fedorenko
2025-09-01 20:03   ` Jakub Kicinski
2025-09-04 19:01     ` Sebastian Basierski
2025-09-05  1:56       ` Jakub Kicinski
2025-09-09 18:47         ` Sebastian Basierski
2025-09-16 23:29           ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250828100237.4076570-4-konrad.leszczynski@intel.com \
    --to=konrad.leszczynski@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=cezary.rojewski@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=karol.jurczenia@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sebastian.basierski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®