From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
James Clark <james.clark@linaro.org>,
Xu Yang <xu.yang_2@nxp.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
John Garry <john.g.garry@oracle.com>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
Sandipan Das <sandipan.das@amd.com>,
Benjamin Gray <bgray@linux.ibm.com>
Subject: [PATCH v5 03/13] perf jevents: Add upc metric for uops per cycle for AMD
Date: Thu, 28 Aug 2025 20:31:28 -0700 [thread overview]
Message-ID: <20250829033138.4166591-4-irogers@google.com> (raw)
In-Reply-To: <20250829033138.4166591-1-irogers@google.com>
The metric adjusts for whether or not SMT is on.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/pmu-events/amd_metrics.py | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/tools/perf/pmu-events/amd_metrics.py b/tools/perf/pmu-events/amd_metrics.py
index 0dd13ddd67d5..3c36078ce727 100755
--- a/tools/perf/pmu-events/amd_metrics.py
+++ b/tools/perf/pmu-events/amd_metrics.py
@@ -1,8 +1,8 @@
#!/usr/bin/env python3
# SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause)
from metric import (d_ratio, has_event, max, Event, JsonEncodeMetric,
- JsonEncodeMetricGroupDescriptions, LoadEvents, Metric,
- MetricGroup, Select)
+ JsonEncodeMetricGroupDescriptions, Literal, LoadEvents,
+ Metric, MetricGroup, Select)
import argparse
import json
import math
@@ -10,8 +10,17 @@ import os
# Global command line arguments.
_args = None
-
+_zen_model: int = 1
interval_sec = Event("duration_time")
+cycles = Event("cycles")
+# Number of CPU cycles scaled for SMT.
+smt_cycles = Select(cycles / 2, Literal("#smt_on"), cycles)
+
+def AmdUpc() -> Metric:
+ ops = Event("ex_ret_ops", "ex_ret_cops")
+ upc = d_ratio(ops, smt_cycles)
+ return Metric("lpm_upc", "Micro-ops retired per core cycle (higher is better)",
+ upc, "uops/cycle")
def Idle() -> Metric:
cyc = Event("msr/mperf/")
@@ -45,6 +54,7 @@ def Rapl() -> MetricGroup:
def main() -> None:
global _args
+ global _zen_model
def dir_path(path: str) -> str:
"""Validate path is a directory for argparse."""
@@ -65,7 +75,10 @@ def main() -> None:
directory = f"{_args.events_path}/x86/{_args.model}/"
LoadEvents(directory)
+ _zen_model = int(_args.model[6:])
+
all_metrics = MetricGroup("", [
+ AmdUpc(),
Idle(),
Rapl(),
])
--
2.51.0.318.gd7df087d1a-goog
next prev parent reply other threads:[~2025-08-29 3:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 3:31 [PATCH v5 00/13] Python generated AMD Zen metrics Ian Rogers
2025-08-29 3:31 ` [PATCH v5 01/13] perf jevents: Add RAPL event metric for AMD zen models Ian Rogers
2025-08-29 3:31 ` [PATCH v5 02/13] perf jevents: Add idle " Ian Rogers
2025-08-29 3:31 ` Ian Rogers [this message]
2025-08-29 3:31 ` [PATCH v5 04/13] perf jevents: Add br metric group for branch statistics on AMD Ian Rogers
2025-08-29 3:31 ` [PATCH v5 05/13] perf jevents: Add software prefetch (swpf) metric group for AMD Ian Rogers
2025-08-29 3:31 ` [PATCH v5 06/13] perf jevents: Add hardware prefetch (hwpf) " Ian Rogers
2025-08-29 3:31 ` [PATCH v5 07/13] perf jevents: Add itlb " Ian Rogers
2025-08-29 3:31 ` [PATCH v5 08/13] perf jevents: Add dtlb " Ian Rogers
2025-08-29 3:31 ` [PATCH v5 09/13] perf jevents: Add uncore l3 " Ian Rogers
2025-08-29 3:31 ` [PATCH v5 10/13] perf jevents: Add load store breakdown metrics ldst " Ian Rogers
2025-08-29 3:31 ` [PATCH v5 11/13] perf jevents: Add ILP metrics " Ian Rogers
2025-08-29 3:31 ` [PATCH v5 12/13] perf jevents: Add context switch " Ian Rogers
2025-08-29 3:31 ` [PATCH v5 13/13] perf jevents: Add uop cache hit/miss rates " Ian Rogers
2025-09-03 14:26 ` [PATCH v5 00/13] Python generated AMD Zen metrics Sandipan Das
2025-09-03 16:08 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829033138.4166591-4-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bgray@linux.ibm.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=sandipan.das@amd.com \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®