mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Erik Beck <xunil@tahomasoft.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Chukun Pan <amadeus@jmu.edu.cn>, Rob Herring <robh@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 0/4] arm64: dts: rockchip: Add HINLINK H66K/H68K
Date: Sat, 30 Aug 2025 17:11:01 -0400	[thread overview]
Message-ID: <20250830171101.410bd954.xunil@tahomasoft.com> (raw)
In-Reply-To: <175603280227.3445205.12980590537074643035.b4-ty@sntech.de>

On Sun, 24 Aug 2025 12:54:40 +0200
Heiko Stuebner <heiko@sntech.de> wrote:

> On Mon, 18 Aug 2025 18:00:05 +0800, Chukun Pan wrote:
> > The HINLINK H66K and H68K are development boards with the Rockchip
> > RK3568 SoC. These boards are all SoM plus expansion board structures.
> > 
> > Both boards can be booted from eMMC or SD-card using the
> > U-Boot 2025.07 generic-rk3568 target.
> > 
> > The SoM board has CPU, RAM, eMMC and RK809 PMIC.
> > There is no schematic for this part.
> > 
> > [...]  
> 
> Applied, thanks!

Hi, apologies in advance if I'm going against protocol, but I'm still really
new at the techniques for Linux patch development.

As you may recall, I've been working on a similar patch for the nearly
identical SeeedStudio LinkStar H68K (v1). I found this recent work from
Chukun earlier today; my work, in part, relied on an offshoot of Chukun's
work from circa 2022 and other inspirations from other rk3568 boards. 
(See
https://lore.kernel.org/linux-devicetree/20250723135008.1077970-1-amadeus@jmu.edu.cn/
for example.)

Chukun's work from 18 August 2025 is better and more complete than where my
code currently is, with one exception: the gmac0/1 phy-modes.

As I worked on my dts, I discovered that the 1Gb ethernet ports, using an
RTL8211, don't support rgmii-id mode; only rgmii.
(https://www.realtek.com/Product/Index?id=3976&cate_id=786). 

Changing this makes a huge difference in the ethernet throughput speed. With
rgmii-id mode specified, throughput is about 6.5 Mbs. Changing this to rgmii
mode increases throughput to about 960 Mbs. 

I tested this on Chukun's code by making that change, and essentially
backporting to my OpenWRT testing profile, using kernel 6.12 and U-Boot 25.04
(also backporting the Hinlink dts to U-Boot).

I saw this over 100x speed difference both with my tree and Chukun's. 

I'll make a note of this in Chukun's patch email for the dts shortly.

I'd like to help support further development of the HinLink/Linkstar patches,
and am happy to base whatever assistance I can provide off Chukun's work. 

Please advise on how I can best contribute.

Regards,

Erik

> 
> [1/4] dt-bindings: vendor-prefixes: Add HINLINK
>       commit: 7d11b8c260ea68ce8f420ad467b04b21ea34b011
> [2/4] dt-bindings: arm: rockchip: Add HINLINK H66K / H68K
>       commit: 4bef07b79ab1ef7d963eaa2c37948030e418d538
> [3/4] arm64: dts: rockchip: Add HINLINK H68K
>       commit: 86a504b82f8d0e34f99ab9607712e7942c919fa3
> [4/4] arm64: dts: rockchip: Add HINLINK H66K
>       commit: bb9ef44f05c9558d58e3c9da141e93af1aa11c1f
> 
> Best regards,


  reply	other threads:[~2025-08-30 21:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 10:00 Chukun Pan
2025-08-18 10:00 ` [PATCH 1/4] dt-bindings: vendor-prefixes: Add HINLINK Chukun Pan
2025-08-18 10:00 ` [PATCH 2/4] dt-bindings: arm: rockchip: Add HINLINK H66K / H68K Chukun Pan
2025-08-18 10:00 ` [PATCH 3/4] arm64: dts: rockchip: Add HINLINK H68K Chukun Pan
2025-08-30 21:14   ` Erik Beck
2025-08-30 21:30     ` Andrew Lunn
2025-08-30 22:21       ` Erik Beck
2025-08-31 14:48         ` Erik Beck
2025-08-31 15:53           ` Andrew Lunn
2025-08-31 16:28             ` Erik Beck
2025-09-01  0:47               ` Andrew Lunn
2025-09-01  7:00     ` Chukun Pan
2025-09-01 10:24       ` Erik Beck
2025-09-01 14:06         ` Erik Beck
2025-09-02  7:00           ` Chukun Pan
2025-09-02 12:10             ` Erik Beck
2025-09-01 16:25         ` Erik Beck
2025-08-18 10:00 ` [PATCH 4/4] arm64: dts: rockchip: Add HINLINK H66K Chukun Pan
2025-08-18 17:27 ` [PATCH 0/4] arm64: dts: rockchip: Add HINLINK H66K/H68K Conor Dooley
2025-08-24 10:54 ` Heiko Stuebner
2025-08-30 21:11   ` Erik Beck [this message]
2025-08-30 21:26     ` Andrew Lunn
2025-08-30 22:20       ` Erik Beck
2025-08-31 13:55         ` Erik Beck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250830171101.410bd954.xunil@tahomasoft.com \
    --to=xunil@tahomasoft.com \
    --cc=amadeus@jmu.edu.cn \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®