From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from r3-17.sinamail.sina.com.cn (r3-17.sinamail.sina.com.cn [202.108.3.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64FD03D81 for ; Sun, 31 Aug 2025 09:59:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.108.3.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756634380; cv=none; b=WB/jsqvwE5EMmN4au37jKBcP7sCipZfpJv5mtT10dp83X4NfuaQuwL1TgmBpxTp+OcQAIkN/TRtWP2Mht49st5i610MlTOnxEWkJV7R1/S8ac3LLVooJhYGPQvg8nhpLXyTozTsHKJ+awKrTchu9+Cd6Pl1K6UuaiSnp/h49fKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756634380; c=relaxed/simple; bh=0KkjeJy5JVJeESV08AjM2dcetdJEMfhjNI6FtNSH/3I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gOwxPhbzOjCuKwBKeo/WHcOZzhbLNykDWIht+6mS3Cr5N/7la+XsRcDwrDmTumEU2GnWMlf6+WQSO8ziy7jCD7hi4hzT0pbkZiV8bHiNq2gqNUFpjV97ojVH4YBJQyTpQWLeoVApuscb1mh2ll4bArOy1hg52APMd6mBUOHugDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b=pczittn8; arc=none smtp.client-ip=202.108.3.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b="pczittn8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sina.com; s=201208; t=1756634376; bh=Loz27QVYNzLeCVfjJCj4j3wpQlM+hqvyO/PA6Ks0kqQ=; h=From:Subject:Date:Message-ID; b=pczittn8x0tMgW3FVfYCZyNrvAuUl+W2UIEy6kaHkqESO3SuUzOjPK+4Ll9uX44oA o7kZdLjh4Dg28f30migt4NJWes9yJIpi0FJMcMQnE3iSJ1gFKWZwiqsLTq0gM5YyDx d4krA/NRXKET0z9QqyB2im+L9DKsTs6mmVV3Q0ZE= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([114.249.58.236]) by sina.com (10.54.253.34) with ESMTP id 68B41CFD00007605; Sun, 31 Aug 2025 17:59:27 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 244656291923 X-SMAIL-UIID: 9199A7AECE71468597CE2A563C8960A6-20250831-175927-1 From: Hillf Danton To: syzbot Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Yunseong Kim , Krzysztof Kozlowski , syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [net?] [nfc?] WARNING in nfc_rfkill_set_block Date: Sun, 31 Aug 2025 17:59:14 +0800 Message-ID: <20250831095915.6269-1-hdanton@sina.com> In-Reply-To: <68b3f389.a00a0220.1337b0.002e.GAE@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > Date: Sun, 31 Aug 2025 00:02:33 -0700 > syzbot has found a reproducer for the following issue on: > > HEAD commit: c8bc81a52d5a Merge tag 'arm64-fixes' of git://git.kernel.o.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1508ce34580000 > kernel config: https://syzkaller.appspot.com/x/.config?x=bd9738e00c1bbfb4 > dashboard link: https://syzkaller.appspot.com/bug?extid=535bbe83dfc3ae8d4be3 > compiler: Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11019a62580000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1308ce34580000 Test Kim's patch. #syz test --- a/net/nfc/core.c +++ b/net/nfc/core.c @@ -1154,6 +1154,7 @@ EXPORT_SYMBOL(nfc_register_device); void nfc_unregister_device(struct nfc_dev *dev) { int rc; + struct rfkill *rfk = NULL; pr_debug("dev_name=%s\n", dev_name(&dev->dev)); @@ -1163,14 +1164,18 @@ void nfc_unregister_device(struct nfc_dev *dev) "was removed\n", dev_name(&dev->dev)); device_lock(&dev->dev); + dev->shutting_down = true; if (dev->rfkill) { - rfkill_unregister(dev->rfkill); - rfkill_destroy(dev->rfkill); + rfk = dev->rfkill; dev->rfkill = NULL; } - dev->shutting_down = true; device_unlock(&dev->dev); + if (rfk) { + rfkill_unregister(rfk); + rfkill_destroy(rfk); + } + if (dev->ops->check_presence) { timer_delete_sync(&dev->check_pres_timer); cancel_work_sync(&dev->check_pres_work); --- x/net/bluetooth/hci_core.c +++ y/net/bluetooth/hci_core.c @@ -1476,8 +1476,14 @@ static void hci_cmd_timeout(struct work_ if (hdev->reset) hdev->reset(hdev); + rcu_read_lock(); + if (hci_dev_test_flag(hdev, HCI_CMD_DRAIN_WORKQUEUE)) { + rcu_read_unlock(); + return; + } atomic_set(&hdev->cmd_cnt, 1); queue_work(hdev->workqueue, &hdev->cmd_work); + rcu_read_unlock(); } /* HCI ncmd timer function */ --