From: "Roy, Patrick" <roypat@amazon.co.uk>
To: "tabba@google.com" <tabba@google.com>
Cc: "ackerleytng@google.com" <ackerleytng@google.com>,
"david@redhat.com" <david@redhat.com>,
"Manwaring, Derek" <derekmn@amazon.com>,
"Thomson, Jack" <jackabt@amazon.co.uk>,
"Kalyazin, Nikita" <kalyazin@amazon.co.uk>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvmarm@lists.linux.dev" <kvmarm@lists.linux.dev>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"Roy, Patrick" <roypat@amazon.co.uk>,
"rppt@kernel.org" <rppt@kernel.org>,
"seanjc@google.com" <seanjc@google.com>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"will@kernel.org" <will@kernel.org>,
"Cali, Marco" <xmarcalx@amazon.co.uk>
Subject: Re: [PATCH v5 02/12] arch: export set_direct_map_valid_noflush to KVM module
Date: Mon, 1 Sep 2025 13:47:00 +0000 [thread overview]
Message-ID: <20250901134659.32171-1-roypat@amazon.co.uk> (raw)
In-Reply-To: <CA+EHjTwDZ-FRV2KfC5ZG9SJYeeMRVUHQ8rVtb9dx2AQwCriPQw@mail.gmail.com>
Hi Fuad!
On Thu, 2025-08-28 at 11:07 +0100, Fuad Tabba wrote:
>> diff --git a/arch/loongarch/mm/pageattr.c b/arch/loongarch/mm/pageattr.c
>> index f5e910b68229..d076bfd3fcbf 100644
>> --- a/arch/loongarch/mm/pageattr.c
>> +++ b/arch/loongarch/mm/pageattr.c
>> @@ -217,6 +217,7 @@ int set_direct_map_invalid_noflush(struct page *page)
>>
>> return __set_memory(addr, 1, __pgprot(0), __pgprot(_PAGE_PRESENT | _PAGE_VALID));
>> }
>> +EXPORT_SYMBOL_FOR_MODULES(set_direct_map_valid_noflush, "kvm");
>
> This should be after 'set_direct_map_valid_noflush', not 'invalid'.
>
> With that fixed:
>
> Reviewed-by: Fuad Tabba <tabba@google.com>
Ah, yes, good catch, thanks!
Best,
Patrick
next prev parent reply other threads:[~2025-09-01 13:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 9:39 [PATCH v5 00/12] Direct Map Removal Support for guest_memfd Roy, Patrick
2025-08-28 9:39 ` [PATCH v5 01/12] filemap: Pass address_space mapping to ->free_folio() Roy, Patrick
2025-08-28 9:39 ` [PATCH v5 02/12] arch: export set_direct_map_valid_noflush to KVM module Roy, Patrick
2025-08-28 10:07 ` Fuad Tabba
2025-09-01 13:47 ` Roy, Patrick [this message]
2025-08-28 9:39 ` [PATCH v5 03/12] mm: introduce AS_NO_DIRECT_MAP Roy, Patrick
2025-08-28 10:21 ` Fuad Tabba
2025-09-01 13:54 ` Roy, Patrick
2025-09-01 14:56 ` Roy, Patrick
2025-09-02 7:59 ` Fuad Tabba
2025-09-02 8:46 ` David Hildenbrand
2025-09-02 8:50 ` Fuad Tabba
2025-09-02 9:18 ` Roy, Patrick
2025-09-02 9:21 ` Fuad Tabba
2025-09-02 9:54 ` David Hildenbrand
2025-08-28 14:26 ` Mike Rapoport
2025-09-01 13:56 ` Roy, Patrick
2025-08-28 21:00 ` David Hildenbrand
2025-09-01 14:03 ` Roy, Patrick
2025-08-31 10:26 ` kernel test robot
2025-09-01 14:05 ` Roy, Patrick
2025-08-28 9:39 ` [PATCH v5 04/12] KVM: guest_memfd: Add flag to remove from direct map Roy, Patrick
2025-08-28 14:54 ` Mike Rapoport
2025-09-01 14:22 ` Roy, Patrick
2025-09-01 14:27 ` Mike Rapoport
2025-08-28 9:39 ` [PATCH v5 05/12] KVM: Documentation: describe GUEST_MEMFD_FLAG_NO_DIRECT_MAP Roy, Patrick
2025-08-28 10:27 ` David Hildenbrand
2025-09-01 14:30 ` Roy, Patrick
2025-09-01 14:43 ` David Hildenbrand
2025-08-28 9:39 ` [PATCH v5 06/12] KVM: selftests: load elf via bounce buffer Roy, Patrick
2025-08-28 9:39 ` [PATCH v5 07/12] KVM: selftests: set KVM_MEM_GUEST_MEMFD in vm_mem_add() if guest_memfd != -1 Roy, Patrick
2025-08-28 9:39 ` [PATCH v5 08/12] KVM: selftests: Add guest_memfd based vm_mem_backing_src_types Roy, Patrick
2025-08-28 9:39 ` [PATCH v5 09/12] KVM: selftests: stuff vm_mem_backing_src_type into vm_shape Roy, Patrick
2025-08-28 9:39 ` [PATCH v5 10/12] KVM: selftests: cover GUEST_MEMFD_FLAG_NO_DIRECT_MAP in mem conversion tests Roy, Patrick
2025-08-28 9:39 ` [PATCH v5 11/12] KVM: selftests: cover GUEST_MEMFD_FLAG_NO_DIRECT_MAP in guest_memfd_test.c Roy, Patrick
2025-08-28 10:26 ` David Hildenbrand
2025-08-28 9:39 ` [PATCH v5 12/12] KVM: selftests: Test guest execution from direct map removed gmem Roy, Patrick
2025-08-28 12:50 ` [PATCH v5 00/12] Direct Map Removal Support for guest_memfd David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250901134659.32171-1-roypat@amazon.co.uk \
--to=roypat@amazon.co.uk \
--cc=ackerleytng@google.com \
--cc=david@redhat.com \
--cc=derekmn@amazon.com \
--cc=jackabt@amazon.co.uk \
--cc=kalyazin@amazon.co.uk \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pbonzini@redhat.com \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
--cc=tabba@google.com \
--cc=vbabka@suse.cz \
--cc=will@kernel.org \
--cc=xmarcalx@amazon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®