From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8DB67246778; Tue, 2 Sep 2025 09:27:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756805239; cv=none; b=WftUMGHI5QsmdBlAnhBmKJE0km0FTVv/idF2QTCAzMEYB8GHSXgsCwso2RipVMV44hzG72VBILsmNLYgdmL2dWD81IVZqBJwhMxP5ftT4TXQX0DcLanPXqbMhFt4wxO1rC1HJyl/1GWkB1mVs9OD0FgHp3339Mt5n6WTpNfiOYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756805239; c=relaxed/simple; bh=IMmePrNbMJSSeHg6trXEyh/maoVMaV0R0jYCCcsItyM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BERtpAuuN78cNsufHPdnPHfpKowzbjKBybGzjAy/+8zjRDwKnjZrT4hYsVIk+UHleYzNIbze5YPpQjC6GTcbSWxVVrjbhuCA5vWSJFO2eB2R2pgX4Bca6g/9RT+2zggL8eN8KJ2WF7EajoQbrXyHqXLtOFcjb1amo3E/JzTRrB0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com; spf=none smtp.mailfrom=foss.arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=foss.arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4EE5B168F; Tue, 2 Sep 2025 02:27:07 -0700 (PDT) Received: from bogus (e133711.arm.com [10.1.196.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7289F3F694; Tue, 2 Sep 2025 02:27:14 -0700 (PDT) Date: Tue, 2 Sep 2025 10:27:11 +0100 From: Sudeep Holla To: Artem Shimko Cc: Cristian Marussi , arm-scmi@vger.kernel.org, Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] firmware: arm_scmi: add missing spinlock documentation Message-ID: <20250902-daft-pompous-angelfish-459c6e@sudeepholla> References: <20250901161207.2501078-1-artyom.shimko@gmail.com> <20250901161207.2501078-3-artyom.shimko@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250901161207.2501078-3-artyom.shimko@gmail.com> On Mon, Sep 01, 2025 at 07:12:04PM +0300, Artem Shimko wrote: > Adds a missing comment for xfer_lock spinlock in struct scmi_xfers_info. > The spinlock protects access to the xfer buffers and transfer allocation > mechanism, preventing race conditions in concurrent access scenarios. > > Signed-off-by: Artem Shimko > --- > drivers/firmware/arm_scmi/driver.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index bd56a877fdfc..6828392152f4 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -76,6 +76,7 @@ static struct dentry *scmi_top_dentry; > */ > struct scmi_xfers_info { > unsigned long *xfer_alloc_table; > + /* Protects access to the xfer buffers */ Thanks for your patch but this is quite obvious and I see no point in just adding this comment. -- Regards, Sudeep