Re: [PATCH V8 2/2] leds: pwm: Add optional GPIO enable pin support

[Lee Jones <lee@kernel.org>]

On Tue, 12 Aug 2025, LI Qingwu wrote:

> 
> 
> > -----Original Message-----
> > From: Lee Jones <lee@kernel.org>
> > Sent: Thursday, July 31, 2025 6:46 PM
> > To: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
> > Cc: pavel@kernel.org; robh@kernel.org; krzk+dt@kernel.org;
> > conor+dt@kernel.org; linux-leds@vger.kernel.org; devicetree@vger.kernel.org;
> > linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH V8 2/2] leds: pwm: Add optional GPIO enable pin support
> > 
> > 
> > On Thu, 24 Jul 2025, LI Qingwu wrote:
> > 
> > > Add support for optional GPIO-based enable pin control to PWM LED driver.
> > > Some PWM LED driver chips like TPS92380 and LT3743 require a separate
> > > enable signal in addition to PWM control. Implement support for such
> > > GPIO control through the "enable-gpios" device tree property,
> > > activating the pin when LED brightness is non-zero and deactivating it when
> > off.
> > >
> > > Tested on i.MX8MP EVK with TPS92380 LED driver chip
> > >
> > > Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
> > > ---
> > >  drivers/leds/leds-pwm.c | 20 ++++++++++++++++++++
> > >  1 file changed, 20 insertions(+)
> > >
> > > diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c index
> > > c73134e7b9514..08a1f735166ad 100644
> > > --- a/drivers/leds/leds-pwm.c
> > > +++ b/drivers/leds/leds-pwm.c
> > > @@ -17,6 +17,7 @@
> > >  #include <linux/err.h>
> > >  #include <linux/pwm.h>
> > >  #include <linux/slab.h>
> > > +#include <linux/gpio/consumer.h>
> > 
> > This list is alphabetical.
> > 
> The original code's include order is not alphabetical,
> If you prefer, I can reorder all or just put "#include <linux/gpio/consumer.h>" to first line,
> Please let me know your preference.

First line is okay for now.

Then, if you feel like it, submit another patch to place them in order.

-- 
Lee Jones [李琼斯]