From: Jinchao Wang <wangjinchao600@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
linux-perf-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Jinchao Wang <wangjinchao600@gmail.com>
Subject: [PATCH 3/3] perf/hw_breakpoint: Skip modify_bp_slot() if slot index unchanged
Date: Wed, 3 Sep 2025 15:51:40 +0800 [thread overview]
Message-ID: <20250903075144.3722848-3-wangjinchao600@gmail.com> (raw)
In-Reply-To: <20250903075144.3722848-1-wangjinchao600@gmail.com>
Only call modify_bp_slot() when the old and new breakpoint types map to
different slot indices.
This avoids unnecessary release/reserve operations and improves efficiency.
Signed-off-by: Jinchao Wang <wangjinchao600@gmail.com>
---
kernel/events/hw_breakpoint.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
index 1db2c5e24d0e..6fed9521baf2 100644
--- a/kernel/events/hw_breakpoint.c
+++ b/kernel/events/hw_breakpoint.c
@@ -752,6 +752,7 @@ modify_user_hw_breakpoint_check(struct perf_event *bp, struct perf_event_attr *a
{
struct arch_hw_breakpoint hw = { };
int err;
+ enum bp_type_idx old_type_idx, new_type_idx;
err = hw_breakpoint_parse(bp, attr, &hw);
if (err)
@@ -766,7 +767,9 @@ modify_user_hw_breakpoint_check(struct perf_event *bp, struct perf_event_attr *a
return -EINVAL;
}
- if (bp->attr.bp_type != attr->bp_type) {
+ old_type_idx = find_slot_idx(bp->attr.bp_type);
+ new_type_idx = find_slot_idx(attr->bp_type);
+ if (old_type_idx != new_type_idx) {
err = modify_bp_slot(bp, bp->attr.bp_type, attr->bp_type);
if (err)
return err;
--
2.43.0
prev parent reply other threads:[~2025-09-03 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 7:51 [PATCH 1/3] perf/hw_breakpoint: Optimize __modify_bp_slot() handling Jinchao Wang
2025-09-03 7:51 ` [PATCH 2/3] perf/hw_breakpoint: Parse before reserving slots Jinchao Wang
2025-09-03 7:51 ` Jinchao Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903075144.3722848-3-wangjinchao600@gmail.com \
--to=wangjinchao600@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®