From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A86F22DA767; Wed, 3 Sep 2025 10:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756894720; cv=none; b=A2nhl9u+fO4/MgL79EjYS3Iv5gPuhHIz9CXHNU9NTmFkLKNCPj8vF3Vu6YKNb+gIgZnKO8MQQ2U6fw/z0n2qbdJvu/yxqeuxCy1lkyRlHHVdtLtaZz1hLM5xh6SlU47GdGKPx4dR5YEJMOZSZ1UIikala+9deMFlvl/UQs7/avA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756894720; c=relaxed/simple; bh=3BDmuX/acgIvSNyMvwX54stjuKITG4fBqBmjib2m/E8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tl1e+A2gP7WhxUDdIHUslJNOtSkg/ApI5IUZu8QlRp1zXObra3D5HZUn8VGMfQJv0bOy817UXt4YA5unFiISzRD2FWWN3ZduBrask6cDVbXz3DhAmCdnQCO0piYc/R4wx9mGjiQRgaZQf4J8+Bb1ZDN/0Ik9KFD4OiwvPnFq6Kg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org; spf=pass smtp.mailfrom=gentoo.org; arc=none smtp.client-ip=140.211.166.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gentoo.org Received: from localhost (unknown [116.232.18.168]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id 8860B340DCC; Wed, 03 Sep 2025 10:18:37 +0000 (UTC) Date: Wed, 3 Sep 2025 18:18:33 +0800 From: Yixun Lan To: Hendrik Hamerlinck Cc: linus.walleij@linaro.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: spacemit: fix typo in PRI_TDI pin name Message-ID: <20250903101833-GYB1155728@gentoo.org> References: <20250903100104.360637-1-hendrik.hamerlinck@hammernet.be> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250903100104.360637-1-hendrik.hamerlinck@hammernet.be> Hi Hendrik, On 12:01 Wed 03 Sep , Hendrik Hamerlinck wrote: > The datasheet lists this signal as PRI_TDI, not PRI_DTI. > Fix the pin name to match the documentation and JTAG naming > convention (TDI = Test Data In). > > Signed-off-by: Hendrik Hamerlinck Reviewed-by: Yixun Lan > --- > drivers/pinctrl/spacemit/pinctrl-k1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/spacemit/pinctrl-k1.c b/drivers/pinctrl/spacemit/pinctrl-k1.c > index 9996b1c4a07e..a3f433b611f7 100644 > --- a/drivers/pinctrl/spacemit/pinctrl-k1.c > +++ b/drivers/pinctrl/spacemit/pinctrl-k1.c > @@ -847,7 +847,7 @@ static const struct pinctrl_pin_desc k1_pin_desc[] = { > PINCTRL_PIN(67, "GPIO_67"), > PINCTRL_PIN(68, "GPIO_68"), > PINCTRL_PIN(69, "GPIO_69"), > - PINCTRL_PIN(70, "GPIO_70/PRI_DTI"), > + PINCTRL_PIN(70, "GPIO_70/PRI_TDI"), > PINCTRL_PIN(71, "GPIO_71/PRI_TMS"), > PINCTRL_PIN(72, "GPIO_72/PRI_TCK"), > PINCTRL_PIN(73, "GPIO_73/PRI_TDO"), > -- > 2.43.0 > -- Yixun Lan (dlan)