From: Jakub Kicinski <kuba@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org,
Horatiu Vultur <horatiu.vultur@microchip.com>,
UNGLinuxDriver@microchip.com (maintainer:MICROCHIP LAN966X
ETHERNET DRIVER), Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk> (maintainer:SFF/SFP/SFP+
MODULE SUPPORT:Keyword:phylink\.h|struct\s+phylink|\.phylink|>,
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCHv2 net-next 2/2] net: lan966x: convert fwnode to of
Date: Wed, 3 Sep 2025 16:55:09 -0700 [thread overview]
Message-ID: <20250903165509.6617e812@kernel.org> (raw)
In-Reply-To: <20250901202001.27024-3-rosenp@gmail.com>
On Mon, 1 Sep 2025 13:20:01 -0700 Rosen Penev wrote:
> This is a purely OF driver. There's no need for fwnode to handle any of
> this, with the exception being phylik_create. Use of_fwnode_handle for
> that.
Not sure this is worth cleaning up, but I'm not an OF API expert.
It's pretty odd that you're sneaking in an extra error check in
such a cleanup patch without even mentioning it.
--
pw-bot: cr
prev parent reply other threads:[~2025-09-03 23:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 20:19 [PATCHv2 net-next 0/2] net: lan966x: some OF cleanups Rosen Penev
2025-09-01 20:20 ` [PATCHv2 net-next 1/2] net: lan966x: use of_get_mac_address Rosen Penev
2025-09-01 20:20 ` [PATCHv2 net-next 2/2] net: lan966x: convert fwnode to of Rosen Penev
2025-09-03 23:55 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903165509.6617e812@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®