Re: [PATCH v3 07/12] ASoC: codecs: wcd-common: move WCD_SDW_CH to common

[kernel test robot <lkp@intel.com>]

Hi Srinivas,

kernel test robot noticed the following build errors:

[auto build test ERROR on broonie-sound/for-next]
[also build test ERROR on linus/master v6.17-rc4 next-20250905]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Srinivas-Kandagatla/ASoC-codecs-wcd937x-set-the-comp-soundwire-port-correctly/20250905-234841
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/20250905154430.12268-8-srinivas.kandagatla%40oss.qualcomm.com
patch subject: [PATCH v3 07/12] ASoC: codecs: wcd-common: move WCD_SDW_CH to common
config: x86_64-buildonly-randconfig-001-20250907 (https://download.01.org/0day-ci/archive/20250907/202509070539.WhfiRSpY-lkp@intel.com/config)
compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250907/202509070539.WhfiRSpY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509070539.WhfiRSpY-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from sound/soc/codecs/wcd937x.h:10,
                    from sound/soc/codecs/wcd937x.c:26:
>> sound/soc/codecs/wcd-common.h:17:8: error: redefinition of 'struct wcd_sdw_ch_info'
      17 | struct wcd_sdw_ch_info {
         |        ^~~~~~~~~~~~~~~
   In file included from sound/soc/codecs/wcd937x.c:24:
   sound/soc/codecs/wcd-common.h:17:8: note: originally defined here
      17 | struct wcd_sdw_ch_info {
         |        ^~~~~~~~~~~~~~~
>> sound/soc/codecs/wcd-common.h:28:8: error: redefinition of 'struct wcd_common'
      28 | struct wcd_common {
         |        ^~~~~~~~~~
   sound/soc/codecs/wcd-common.h:28:8: note: originally defined here
      28 | struct wcd_common {
         |        ^~~~~~~~~~
>> sound/soc/codecs/wcd-common.h:36:5: error: conflicting types for 'wcd_dt_parse_micbias_info'; have 'int(struct wcd_common *)'
      36 | int wcd_dt_parse_micbias_info(struct wcd_common *common);
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~
   sound/soc/codecs/wcd-common.h:36:5: note: previous declaration of 'wcd_dt_parse_micbias_info' with type 'int(struct wcd_common *)'
      36 | int wcd_dt_parse_micbias_info(struct wcd_common *common);
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~
   sound/soc/codecs/wcd937x.c: In function 'wcd937x_connect_port':
>> sound/soc/codecs/wcd937x.c:1186:53: error: initialization of 'const struct wcd937x_sdw_ch_info *' from incompatible pointer type 'struct wcd_sdw_ch_info *' [-Werror=incompatible-pointer-types]
    1186 |         const struct wcd937x_sdw_ch_info *ch_info = &wcd->ch_info[ch_id];
         |                                                     ^
>> sound/soc/codecs/wcd937x.c:1187:30: error: invalid use of undefined type 'const struct wcd937x_sdw_ch_info'
    1187 |         u8 port_num = ch_info->port_num;
         |                              ^~
   sound/soc/codecs/wcd937x.c:1188:29: error: invalid use of undefined type 'const struct wcd937x_sdw_ch_info'
    1188 |         u8 ch_mask = ch_info->ch_mask;
         |                             ^~
   sound/soc/codecs/wcd937x.c:1195:31: error: invalid use of undefined type 'const struct wcd937x_sdw_ch_info'
    1195 |         mstr_ch_mask = ch_info->master_ch_mask;
         |                               ^~
   sound/soc/codecs/wcd937x.c: In function 'wcd937x_mbhc_micb_ctrl_threshold_mic':
   sound/soc/codecs/wcd937x.c:1522:20: error: 'struct wcd937x_priv' has no member named 'micb2_mv'
    1522 |         if (wcd937x->micb2_mv >= WCD_MBHC_THR_HS_MICB_MV)
         |                    ^~
   sound/soc/codecs/wcd937x.c:1525:61: error: 'struct wcd937x_priv' has no member named 'micb2_mv'
    1525 |         micb_mv = req_en ? WCD_MBHC_THR_HS_MICB_MV : wcd937x->micb2_mv;
         |                                                             ^~
   sound/soc/codecs/wcd937x.c: In function 'wcd937x_set_micbias_data':
   sound/soc/codecs/wcd937x.c:2432:34: error: 'struct wcd937x_priv' has no member named 'commmon'; did you mean 'common'?
    2432 |                         wcd937x->commmon.micb_vout[0]);
         |                                  ^~~~~~~
         |                                  common
   sound/soc/codecs/wcd937x.c:2434:34: error: 'struct wcd937x_priv' has no member named 'commmon'; did you mean 'common'?
    2434 |                         wcd937x->commmon.micb_vout[1]);
         |                                  ^~~~~~~
         |                                  common
   sound/soc/codecs/wcd937x.c:2436:34: error: 'struct wcd937x_priv' has no member named 'commmon'; did you mean 'common'?
    2436 |                         wcd937x->commmon.micb_vout[2]);
         |                                  ^~~~~~~
         |                                  common
   sound/soc/codecs/wcd937x.c: In function 'wcd937x_probe':
   sound/soc/codecs/wcd937x.c:2897:41: error: passing argument 1 of 'wcd_dt_parse_micbias_info' from incompatible pointer type [-Werror=incompatible-pointer-types]
    2897 |         ret = wcd_dt_parse_micbias_info(dev, &wcd937x->common);
         |                                         ^~~
         |                                         |
         |                                         struct device *
   sound/soc/codecs/wcd-common.h:36:50: note: expected 'struct wcd_common *' but argument is of type 'struct device *'
      36 | int wcd_dt_parse_micbias_info(struct wcd_common *common);
         |                               ~~~~~~~~~~~~~~~~~~~^~~~~~
   sound/soc/codecs/wcd937x.c:2897:15: error: too many arguments to function 'wcd_dt_parse_micbias_info'
    2897 |         ret = wcd_dt_parse_micbias_info(dev, &wcd937x->common);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~
   sound/soc/codecs/wcd-common.h:36:5: note: declared here
      36 | int wcd_dt_parse_micbias_info(struct wcd_common *common);
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~
   sound/soc/codecs/wcd937x.c:2905:31: error: 'struct wcd937x_priv' has no member named 'micb2_mv'
    2905 |         cfg->micb_mv = wcd937x->micb2_mv;
         |                               ^~
   cc1: some warnings being treated as errors
--
   sound/soc/codecs/wcd937x-sdw.c: In function 'wcd9370_probe':
>> sound/soc/codecs/wcd937x-sdw.c:1075:40: error: 'struct wcd_sdw_ch_info' has no member named 'master_ch_mask'
    1075 |                         wcd->ch_info[i].master_ch_mask = WCD937X_SWRM_CH_MASK(master_ch_mask[i]);
         |                                        ^
   sound/soc/codecs/wcd937x-sdw.c:1092:40: error: 'struct wcd_sdw_ch_info' has no member named 'master_ch_mask'
    1092 |                         wcd->ch_info[i].master_ch_mask = WCD937X_SWRM_CH_MASK(master_ch_mask[i]);
         |                                        ^


vim +17 sound/soc/codecs/wcd-common.h

    16	
  > 17	struct wcd_sdw_ch_info {
    18		int port_num;
    19		unsigned int ch_mask;
    20	};
    21	
    22	#define WCD_SDW_CH(id, pn, cmask)	\
    23		[id] = {			\
    24			.port_num = pn,		\
    25			.ch_mask = cmask,	\
    26		}
    27	
  > 28	struct wcd_common {
    29		struct device *dev;
    30		int max_bias;
    31		u32 micb_mv[WCD_MAX_MICBIAS];
    32		u32 micb_vout[WCD_MAX_MICBIAS];
    33	};
    34	
    35	int wcd_get_micb_vout_ctl_val(struct device *dev, u32 micb_mv);
  > 36	int wcd_dt_parse_micbias_info(struct wcd_common *common);
    37	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki