mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Carlos Llamas <cmllamas@google.com>,
	 Elliot Berman <quic_eberman@quicinc.com>,
	 Stephen Boyd <swboyd@chromium.org>,
	Breno Leitao <leitao@debian.org>,
	 Luca Ceresoli <luca.ceresoli@bootlin.com>,
	linux-kernel@vger.kernel.org,
	 "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Subject: [PATCH 1/3] scripts/decode_stacktrace.sh: symbol: avoid trailing whitespaces
Date: Mon, 08 Sep 2025 17:41:57 +0200	[thread overview]
Message-ID: <20250908-decode_strace_indent-v1-1-28e5e4758080@kernel.org> (raw)
In-Reply-To: <20250908-decode_strace_indent-v1-0-28e5e4758080@kernel.org>

Lines having a symbol to decode might not always have info after this
symbol. It means ${info_str} might not be set, but it will always be
printed after a space, causing trailing whitespaces.

That's a detail, but when the output is opened with an editor marking
these trailing whitespaces, that's a bit disturbing. It is easy to
remove them by printing this variable with a space only if it is set.

While at it, do the same with ${module} and print everything in one line.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
 scripts/decode_stacktrace.sh | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
index 17abc4e7a9855b10e76acfdb92847e1671d6c2bd..c6b5c14412f0f6f78fb60b0b042d6e22bbb46b79 100755
--- a/scripts/decode_stacktrace.sh
+++ b/scripts/decode_stacktrace.sh
@@ -323,12 +323,7 @@ handle_line() {
 	parse_symbol # modifies $symbol
 
 	# Add up the line number to the symbol
-	if [[ -z ${module} ]]
-	then
-		echo "${words[@]}" "$symbol ${info_str}"
-	else
-		echo "${words[@]}" "$symbol $module ${info_str}"
-	fi
+	echo "${words[@]}" "${symbol}${module:+ ${module}}${info_str:+ ${info_str}}"
 }
 
 while read line; do

-- 
2.51.0


  reply	other threads:[~2025-09-08 15:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08 15:41 [PATCH 0/3] scripts/decode_stacktrace.sh: preserve alignment Matthieu Baerts (NGI0)
2025-09-08 15:41 ` Matthieu Baerts (NGI0) [this message]
2025-09-08 16:18   ` [PATCH 1/3] scripts/decode_stacktrace.sh: symbol: avoid trailing whitespaces Carlos Llamas
2025-09-10  9:15   ` Luca Ceresoli
2025-09-10 13:07   ` Breno Leitao
2025-09-08 15:41 ` [PATCH 2/3] scripts/decode_stacktrace.sh: symbol: preserve alignment Matthieu Baerts (NGI0)
2025-09-08 16:22   ` Carlos Llamas
2025-09-08 15:41 ` [PATCH 3/3] scripts/decode_stacktrace.sh: code: " Matthieu Baerts (NGI0)
2025-09-08 16:33   ` Carlos Llamas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250908-decode_strace_indent-v1-1-28e5e4758080@kernel.org \
    --to=matttbe@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cmllamas@google.com \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=quic_eberman@quicinc.com \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®