From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
Dan Carpenter <dan.carpenter@linaro.org>,
Zenghui Yu <yuzenghui@huawei.com>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>
Subject: [PATCH v2 RESEND 2/3] irqchip/gic-v5: Fix loop in gicv5_its_create_itt_two_level() cleanup path
Date: Mon, 8 Sep 2025 10:27:44 +0200 [thread overview]
Message-ID: <20250908082745.113718-3-lpieralisi@kernel.org> (raw)
In-Reply-To: <20250908082745.113718-1-lpieralisi@kernel.org>
From: Dan Carpenter <dan.carpenter@linaro.org>
The "i" variable in gicv5_its_create_itt_two_level() needs to be signed
otherwise it would cause a forever loop in the function cleanup path.
[lpieralisi: reworded commit log]
Fixes: 57d72196dfc8 ("irqchip/gic-v5: Add GICv5 ITS support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <maz@kernel.org>
---
drivers/irqchip/irq-gic-v5-its.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
index 9290ac741949..4701ef62b8b2 100644
--- a/drivers/irqchip/irq-gic-v5-its.c
+++ b/drivers/irqchip/irq-gic-v5-its.c
@@ -191,9 +191,9 @@ static int gicv5_its_create_itt_two_level(struct gicv5_its_chip_data *its,
unsigned int num_events)
{
unsigned int l1_bits, l2_bits, span, events_per_l2_table;
- unsigned int i, complete_tables, final_span, num_ents;
+ unsigned int complete_tables, final_span, num_ents;
__le64 *itt_l1, *itt_l2, **l2ptrs;
- int ret;
+ int i, ret;
u64 val;
ret = gicv5_its_l2sz_to_l2_bits(itt_l2sz);
--
2.48.0
next prev parent reply other threads:[~2025-09-08 8:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 8:27 [PATCH v2 RESEND 0/3] irqchip/gic-v5: Holdover fixes Lorenzo Pieralisi
2025-09-08 8:27 ` [PATCH v2 RESEND 1/3] irqchip/gic-v5: Delete a stray tab Lorenzo Pieralisi
2025-09-09 9:52 ` [tip: irq/drivers] " tip-bot2 for Dan Carpenter
2025-09-08 8:27 ` Lorenzo Pieralisi [this message]
2025-09-09 9:51 ` [tip: irq/drivers] irqchip/gic-v5: Fix loop in gicv5_its_create_itt_two_level() cleanup path tip-bot2 for Dan Carpenter
2025-09-08 8:27 ` [PATCH v2 RESEND 3/3] irqchip/gic-v5: Fix error handling in gicv5_its_irq_domain_alloc() Lorenzo Pieralisi
2025-09-09 9:51 ` [tip: irq/drivers] " tip-bot2 for Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250908082745.113718-3-lpieralisi@kernel.org \
--to=lpieralisi@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®