From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
To: Donald Hunter <donald.hunter@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Subject: [PATCH net-next 1/8] tools: ynl: fix undefined variable name
Date: Tue, 09 Sep 2025 23:07:47 +0200 [thread overview]
Message-ID: <20250909-net-next-ynl-ruff-v1-1-238c2bccdd99@kernel.org> (raw)
In-Reply-To: <20250909-net-next-ynl-ruff-v1-0-238c2bccdd99@kernel.org>
This variable used in the error path was not defined according to Ruff.
msg_format.attr_set is used instead, presumably the one that was
supposed to be used originally.
This is linked to Ruff error F821 [1]:
An undefined name is likely to raise NameError at runtime.
Fixes: 1769e2be4baa ("tools/net/ynl: Add 'sub-message' attribute decoding to ynl")
Link: https://docs.astral.sh/ruff/rules/undefined-name/ [1]
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Notes: I don't know if such fix can be queued to 'net'. It is in the
error path, it doesn't seem required to backport it.
---
tools/net/ynl/pyynl/lib/ynl.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/net/ynl/pyynl/lib/ynl.py b/tools/net/ynl/pyynl/lib/ynl.py
index 8244a5f440b2be8f08f8424270a4dbd67a81a80d..15ddb0b1adb63f5853bf58579687d160a9c46860 100644
--- a/tools/net/ynl/pyynl/lib/ynl.py
+++ b/tools/net/ynl/pyynl/lib/ynl.py
@@ -746,7 +746,7 @@ class YnlFamily(SpecFamily):
subdict = self._decode(NlAttrs(attr.raw, offset), msg_format.attr_set)
decoded.update(subdict)
else:
- raise Exception(f"Unknown attribute-set '{attr_space}' when decoding '{attr_spec.name}'")
+ raise Exception(f"Unknown attribute-set '{msg_format.attr_set}' when decoding '{attr_spec.name}'")
return decoded
def _decode(self, attrs, space, outer_attrs = None):
--
2.51.0
next prev parent reply other threads:[~2025-09-09 21:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 21:07 [PATCH net-next 0/8] tools: ynl: fix errors reported by Ruff Matthieu Baerts (NGI0)
2025-09-09 21:07 ` Matthieu Baerts (NGI0) [this message]
2025-09-09 21:07 ` [PATCH net-next 2/8] tools: ynl: avoid bare except Matthieu Baerts (NGI0)
2025-09-09 21:07 ` [PATCH net-next 3/8] tools: ynl: remove assigned but never used variable Matthieu Baerts (NGI0)
2025-09-09 21:07 ` [PATCH net-next 4/8] tools: ynl: remove f-string without any placeholders Matthieu Baerts (NGI0)
2025-09-09 21:07 ` [PATCH net-next 5/8] tools: ynl: remove unused imports Matthieu Baerts (NGI0)
2025-09-09 21:07 ` [PATCH net-next 6/8] tools: ynl: remove unnecessary semicolons Matthieu Baerts (NGI0)
2025-09-09 21:07 ` [PATCH net-next 7/8] tools: ynl: use 'cond is None' Matthieu Baerts (NGI0)
2025-09-09 21:07 ` [PATCH net-next 8/8] tools: ynl: check for membership with 'not in' Matthieu Baerts (NGI0)
2025-09-10 8:53 ` [PATCH net-next 0/8] tools: ynl: fix errors reported by Ruff Donald Hunter
2025-09-10 23:16 ` Asbjørn Sloth Tønnesen
2025-09-11 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909-net-next-ynl-ruff-v1-1-238c2bccdd99@kernel.org \
--to=matttbe@kernel.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®