Re: [PATCH v3 6/8] arm64: dts: bst: add support for Black Sesame Technologies C1200 CDCU1.0 board

[Albert Yang <yangzh0906@thundersoft.com>]

On Fri, Sep 05, 2025 at 09:23:48AM +0200, Krzysztof Kozlowski wrote:
> On 03/09/2025 09:06, Albert Yang wrote:
> >>

> > However, I'm uncertain about how to order properties that start with "#".
> > I have treated them as standard/common properties and updated the node as follows.
> > Could you please confirm if this approach is correct?
>
> They go as standard common properties. Whether you group all '#'
> together or sort by name skipping '#' is up to you, because common style
> does not define that.
>
> >
> >
> >             gic: interrupt-controller@32800000 {
> >                     compatible = "arm,gic-v3";
> >                     reg = <0x0 0x32800000 0x0 0x10000>,
> >                           <0x0 0x32880000 0x0 0x100000>;
> >                     ranges;
> >                     #address-cells = <2>;
> >                     #interrupt-cells = <3>;
> >                     interrupt-controller;
> >                     interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_LOW>;
> >                     #size-cells = <2>;
>
> I would keep #size-cells after #address-cells, because they describe
> same thing - addressing of children.

Thank you for your feedback and confirmation. I will update the node 
according to your suggestions as follows:

        gic: interrupt-controller@32800000 {
            compatible = "arm,gic-v3";
            reg = <0x0 0x32800000 0x0 0x10000>,
                  <0x0 0x32880000 0x0 0x100000>;
            ranges;
            #address-cells = <2>;
            #size-cells = <2>;
            #interrupt-cells = <3>;
            interrupt-controller;
            interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_LOW>;
        };

Best Regards,
Albert