From: Martin Hecht <mhecht73@gmail.com>
To: linux-media@vger.kernel.org
Cc: sakari.ailus@linux.intel.com, michael.roeder@avnet.eu,
martin.hecht@avnet.eu, Martin Hecht <mhecht73@gmail.com>,
Tommaso Merciai <tomm.merciai@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2] media: i2c: alvium: cleanup media bus formats
Date: Tue, 9 Sep 2025 15:59:37 +0200 [thread overview]
Message-ID: <20250909135938.2841635-1-mhecht73@gmail.com> (raw)
This patch removes MEDIA_BUS_FMT_RBG888_1X24 and MEDIA_BUS_FMT_BGR888_1X24
as of that formats are not supported by Alvium currently.
The missing and supported MEDIA_BUS_FMT_RGB565_1X16 has been added.
Signed-off-by: Martin Hecht <mhecht73@gmail.com>
---
changes since v1:
- subject changed because typo
drivers/media/i2c/alvium-csi2.c | 28 +++++++++-------------------
drivers/media/i2c/alvium-csi2.h | 3 +--
2 files changed, 10 insertions(+), 21 deletions(-)
diff --git a/drivers/media/i2c/alvium-csi2.c b/drivers/media/i2c/alvium-csi2.c
index c63af96d3b31..743b300fba4c 100644
--- a/drivers/media/i2c/alvium-csi2.c
+++ b/drivers/media/i2c/alvium-csi2.c
@@ -94,19 +94,9 @@ static const struct alvium_pixfmt alvium_csi2_fmts[] = {
.bay_fmt_regval = -1,
.is_raw = 0,
}, {
- /* RBG888_1X24 */
- .id = ALVIUM_FMT_RBG888_1X24,
- .code = MEDIA_BUS_FMT_RBG888_1X24,
- .colorspace = V4L2_COLORSPACE_SRGB,
- .fmt_av_bit = ALVIUM_BIT_RGB888,
- .bay_av_bit = ALVIUM_BIT_BAY_NONE,
- .mipi_fmt_regval = MIPI_CSI2_DT_RGB888,
- .bay_fmt_regval = -1,
- .is_raw = 0,
- }, {
- /* BGR888_1X24 */
- .id = ALVIUM_FMT_BGR888_1X24,
- .code = MEDIA_BUS_FMT_BGR888_1X24,
+ /* RGB888_3X8 */
+ .id = ALVIUM_FMT_RGB888_3X8,
+ .code = MEDIA_BUS_FMT_RGB888_3X8,
.colorspace = V4L2_COLORSPACE_SRGB,
.fmt_av_bit = ALVIUM_BIT_RGB888,
.bay_av_bit = ALVIUM_BIT_BAY_NONE,
@@ -114,15 +104,15 @@ static const struct alvium_pixfmt alvium_csi2_fmts[] = {
.bay_fmt_regval = -1,
.is_raw = 0,
}, {
- /* RGB888_3X8 */
- .id = ALVIUM_FMT_RGB888_3X8,
- .code = MEDIA_BUS_FMT_RGB888_3X8,
+ /* RGB565_1X16 */
+ .id = ALVIUM_FMT_RGB565_1X16,
+ .code = MEDIA_BUS_FMT_RGB565_1X16,
.colorspace = V4L2_COLORSPACE_SRGB,
- .fmt_av_bit = ALVIUM_BIT_RGB888,
+ .fmt_av_bit = ALVIUM_BIT_RGB565,
.bay_av_bit = ALVIUM_BIT_BAY_NONE,
- .mipi_fmt_regval = MIPI_CSI2_DT_RGB888,
+ .mipi_fmt_regval = MIPI_CSI2_DT_RGB565,
.bay_fmt_regval = -1,
- .is_raw = 0,
+ .is_raw = 0,
}, {
/* Y8_1X8 */
.id = ALVIUM_FMT_Y8_1X8,
diff --git a/drivers/media/i2c/alvium-csi2.h b/drivers/media/i2c/alvium-csi2.h
index 978af44f76c7..0f1af5e5355c 100644
--- a/drivers/media/i2c/alvium-csi2.h
+++ b/drivers/media/i2c/alvium-csi2.h
@@ -224,9 +224,8 @@ enum alvium_mipi_fmt {
ALVIUM_FMT_YUYV8_2X8,
ALVIUM_FMT_YUYV10_1X20,
ALVIUM_FMT_RGB888_1X24,
- ALVIUM_FMT_RBG888_1X24,
- ALVIUM_FMT_BGR888_1X24,
ALVIUM_FMT_RGB888_3X8,
+ ALVIUM_FMT_RGB565_1X16,
ALVIUM_FMT_Y8_1X8,
ALVIUM_FMT_SGRBG8_1X8,
ALVIUM_FMT_SRGGB8_1X8,
--
2.43.0
next reply other threads:[~2025-09-09 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 13:59 Martin Hecht [this message]
2025-09-11 12:14 ` Sakari Ailus
2025-09-11 15:11 ` Martin Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909135938.2841635-1-mhecht73@gmail.com \
--to=mhecht73@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.hecht@avnet.eu \
--cc=mchehab@kernel.org \
--cc=michael.roeder@avnet.eu \
--cc=sakari.ailus@linux.intel.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®