From: Colin Ian King <colin.i.king@gmail.com>
To: Yinbo Zhu <zhuyinbo@loongson.cn>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>, Yao Zi <ziyao@disroot.org>,
Huacai Chen <chenhuacai@kernel.org>,
linux-gpio@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH][next] gpio: loongson-64bit: Fix a less than zero check on an unsigned int struct field
Date: Tue, 9 Sep 2025 20:03:56 +0100 [thread overview]
Message-ID: <20250909190356.870000-1-colin.i.king@gmail.com> (raw)
Currently the error check from the call to platform_get_irq is always
false because an unsigned int chip->irq.parents[i] is being used to
to perform the less than zero error check. Fix this by using the int
variable ret to perform the check.
Fixes: 03c146cb6cd1 ("gpio: loongson-64bit: Add support for Loongson-2K0300 SoC")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/gpio/gpio-loongson-64bit.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-loongson-64bit.c b/drivers/gpio/gpio-loongson-64bit.c
index f84f8c537249..24b7219db34a 100644
--- a/drivers/gpio/gpio-loongson-64bit.c
+++ b/drivers/gpio/gpio-loongson-64bit.c
@@ -267,10 +267,13 @@ static int loongson_gpio_init_irqchip(struct platform_device *pdev,
return -ENOMEM;
for (i = 0; i < data->intr_num; i++) {
- chip->irq.parents[i] = platform_get_irq(pdev, i);
- if (chip->irq.parents[i] < 0)
- return dev_err_probe(&pdev->dev, chip->irq.parents[i],
+ int ret;
+
+ ret = platform_get_irq(pdev, i);
+ if (ret < 0)
+ return dev_err_probe(&pdev->dev, ret,
"failed to get IRQ %d\n", i);
+ chip->irq.parents[i] = ret;
}
for (i = 0; i < data->intr_num; i++) {
--
2.51.0
next reply other threads:[~2025-09-09 19:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 19:03 Colin Ian King [this message]
2025-09-10 3:09 ` Yao Zi
2025-09-10 3:13 ` Huacai Chen
2025-09-10 8:15 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909190356.870000-1-colin.i.king@gmail.com \
--to=colin.i.king@gmail.com \
--cc=brgl@bgdev.pl \
--cc=chenhuacai@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhuyinbo@loongson.cn \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®