Re: [PATCH 5.15 00/64] 5.15.192-rc1 review

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Sep 08, 2025 at 11:54:56PM +0530, Naresh Kamboju wrote:
> On Mon, 8 Sept 2025 at 01:43, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 5.15.192 release.
> > There are 64 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Tue, 09 Sep 2025 19:55:53 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.192-rc1.gz
> > or in the git tree and branch at:
> >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> 
> While building Linux stable-rc 5.15.192-rc1 the arm64 allyesconfig
> builds failed.
> 
> * arm64, build
>   - gcc-12-allyesconfig
> 
> Regression Analysis:
> - New regression? yes
> - Reproducibility? yes
> 
> Build regression: stable-rc 5.15.192-rc1 arm64 allyesconfig
> qede_main.c:199:35: error: initialization of void from incompatible
> pointer
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> ### build log
> drivers/net/ethernet/qlogic/qede/qede_main.c:199:35: error:
> initialization of 'void (*)(void *, u16,  u16)' {aka 'void (*)(void *,
> short unsigned int,  short unsigned int)'} from incompatible pointer
> type 'void (*)(void *, void *, u8)' {aka 'void (*)(void *, void *,
> unsigned char)'} [-Werror=incompatible-pointer-types]
>   199 |                 .arfs_filter_op = qede_arfs_filter_op,
>       |                                   ^~~~~~~~~~~~~~~~~~~
> 
> This was reported on the Linux next-20250428 tag,
> https://lore.kernel.org/all/CA+G9fYs+7-Jut2PM1Z8fXOkBaBuGt0WwTUvU=4cu2O8iQdwUYw@mail.gmail.com/

Odd, I can't reproduce this here, and nothing has changed in this driver
at all for this -rc cycle.  I see no one responded to the linux-next
issue either, so any hints?

Also, the definition seems wrong from what you built, here it is with
the -rc patch applied:

	$ git grep arfs_filter_op
	drivers/net/ethernet/qlogic/qed/qed_l2.c:       op->arfs_filter_op(dev, cookie, fw_return_code);
	drivers/net/ethernet/qlogic/qede/qede.h:void qede_arfs_filter_op(void *dev, void *filter, u8 fw_rc);
	drivers/net/ethernet/qlogic/qede/qede_filter.c:void qede_arfs_filter_op(void *dev, void *filter, u8 fw_rc)
	drivers/net/ethernet/qlogic/qede/qede_main.c:           .arfs_filter_op = qede_arfs_filter_op,
	include/linux/qed/qed_if.h:     void (*arfs_filter_op)(void *dev, void *fltr, u8 fw_rc);

No u16 stuff at all here.

thanks,

greg k-h