From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 267822686A0 for ; Wed, 10 Sep 2025 05:33:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757482411; cv=none; b=IqhQCl1Sf1DP4y5eKoK9cyLNDIWpkFlBJmRqXUMeKq6ZRWYHP7urNwRdX/40NBtaUmP2XZU+Ipz+CCA24WssvdhmrEae2MA7Lk7EpSamMHIOlq+ze3UIde6fmGPrNwx0R0fpmoFSykyw9Wwvxl49i9dXV7PxGgUw7y8Qce6gfd4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757482411; c=relaxed/simple; bh=TY/ZZj6bG0AIJATrDHUHJIWSY2uar3+Ji9ucd5qqXlQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T8PUq5bY5VAzX+hcsnjpZnKc360hldzkMGcS/hQSMEiRqI015FkgU047tCbj8XvuG+eXPfBk35P/onYD+c8Z1gSXegpeKdEJ9PWDAEe8iPd/N1mZZtbKYQIJ1GK4JJY39QkR1i38pNaMQVqWHJYZTQklvmSfubDNj6dOQFLoiwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J8C+ukqy; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J8C+ukqy" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-77251d7cca6so5398498b3a.3 for ; Tue, 09 Sep 2025 22:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757482409; x=1758087209; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nFJjjziwY/SMZUE7K7JOobhYkWwkFReGMU9dNIU9Js8=; b=J8C+ukqyIq0BhHfA0CRagVixaZyo/TWiGScgTvdhMZl2gfsqaji+9+/86kBb3w7nhm AsY0Yt8iNQ0Ar182QkDYZdipxHnl6B5wIdcArOkfPxGocmf0O2K6cHpGzzA8HYyjrAd4 EuE/QNolZhke9inEAV+zsQFeFPQSbfX/9mmT7ODce5V+ZuVUYh3SBOzEwabTg+H4/djt EGcQqTQa3/osK/P/FW3tvY+XNgGlgWnmJs6GMs/TyTIYd61LZaeVY6rU3K4NLF9s9mGi KyIIbKq6ipiA56y6TJbWmhbP5+9hNsUb9joWGHPQiXPQgQO6Iz+pnFc/bWeNhTFHtY0j lDwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757482409; x=1758087209; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nFJjjziwY/SMZUE7K7JOobhYkWwkFReGMU9dNIU9Js8=; b=nO4+/7YG1I2h+/v1/Cc6ZDJeKDTf6UwacRx+tewJAbU6+Xm7v27WVOiJ+2dPIDmWKA AVioliEIl5jNng8JmTcbMpSuKMC8oOTWFgAeU67VZJeeR7k/TuueQtymMyUgzp23Vqyo /a4fvEPfmRbsGNARBIcS8E6vuO+UIph5XBlMKsdKVuSQ8rzkUAmtGFdzazPUFoBNbnea 6VEKJ/nIYc7UfDWEKtn3NIs71xIgpFDU4z5OHEzpPtLVPiGjsJWNBc8Pilh6cJMS1eq3 pDoz3Xva70stiu2maL8dk6tiQw+QFXMvWRJkYdYW9VriTCqzsHIbvjA/HSbCb1vWhVNW 0Tyg== X-Gm-Message-State: AOJu0YyWZUM7C2BaCn7vTTwI/WOv/JdojrRV0/KqsUairubqYjthvnLS H094ZVe+OzslkmoFBCXmdTDcpAiPHkCC32oydrpirHlL3r3OtezxJZtB X-Gm-Gg: ASbGncsHCcCbSEhaPH4FUYaRVRFYC3zg5Rei4Y551qzCYx16DwK41hISU8k/H880HRR /rkdvCspm1A9n3dp0S1Dgy9IKHWUZXyei6HCvEVYH9VNUTaDLs68HhvOAlwfdaLSC4eHTblq6pF QldCgC5HoA/WmQTC0idBQ5JfZ5VWu4Fz5ARXsevrSz4sMIi7hUoGFDfVi2yz5For5LxMWDNktz7 Iwksi4s1FFBRRvc/rrAKkUCn9jLf1WffnYhqZNE3cOm51Nis+wOfcvVujlzPQadugC/ENwrCcHh yY2N6BG1j+Py9o//SRwfPJv8P/U1darSOFcWDGf8b+P+TS7t0AhmI4IxmrIgvi67j/q1HTovwbC pKBhf5DKIRNTuJ8QeY5liE1foyap2L3FQkLl3FhsBjaW/4jGaw8vpWrenXctb X-Google-Smtp-Source: AGHT+IFSzMJtTgRp6G6+ynwQIuI7wFxwrcxpY0ttE5gtXrdyaN2igD3J3QxBSKtHfOz9fDuR2ISq9Q== X-Received: by 2002:a05:6a00:3c8a:b0:772:4d52:ce5a with SMTP id d2e1a72fcca58-7742de4244cmr15474546b3a.26.1757482409245; Tue, 09 Sep 2025 22:33:29 -0700 (PDT) Received: from localhost.localdomain ([45.8.220.62]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7746628ffbesm3870342b3a.66.2025.09.09.22.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Sep 2025 22:33:28 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , "Naveen N . Rao" , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Steven Rostedt , Mathieu Desnoyers , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jinchao Wang Subject: [PATCH v3 16/19] mm/ksw: add silent corruption test case Date: Wed, 10 Sep 2025 13:31:14 +0800 Message-ID: <20250910053147.1152253-8-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250910053147.1152253-1-wangjinchao600@gmail.com> References: <20250910052335.1151048-1-wangjinchao600@gmail.com> <20250910053147.1152253-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce a new test scenario to simulate silent stack corruption: - silent_corruption_buggy(): exposes a local variable address globally without resetting it. - silent_corruption_unwitting(): reads the exposed pointer and modifies the memory, simulating a routine that unknowingly writes to another stack frame. - silent_corruption_victim(): demonstrates the effect of silent corruption on unrelated local variables. Signed-off-by: Jinchao Wang --- mm/kstackwatch/test.c | 93 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 92 insertions(+), 1 deletion(-) diff --git a/mm/kstackwatch/test.c b/mm/kstackwatch/test.c index ab1a3f92b5e8..b10465381089 100644 --- a/mm/kstackwatch/test.c +++ b/mm/kstackwatch/test.c @@ -20,6 +20,9 @@ static struct proc_dir_entry *test_proc; #define BUFFER_SIZE 4 #define MAX_DEPTH 6 +/* global variables for Silent corruption test */ +static u64 *g_corrupt_ptr; + /* * Test Case 0: Write to the canary position directly (Canary Test) * use a u64 buffer array to ensure the canary will be placed @@ -61,6 +64,89 @@ static void canary_test_overflow(void) pr_info("canary overflow test completed\n"); } +static void do_something(int min_ms, int max_ms) +{ + u32 rand; + + get_random_bytes(&rand, sizeof(rand)); + rand = min_ms + rand % (max_ms - min_ms + 1); + msleep(rand); +} + +static void silent_corruption_buggy(int i) +{ + u64 local_var; + + pr_info("starting %s\n", __func__); + + pr_info("%s %d local_var addr: 0x%lx\n", __func__, i, + (unsigned long)&local_var); + WRITE_ONCE(g_corrupt_ptr, &local_var); + do_something(0, 300); + //buggy: return without resetting g_corrupt_ptr +} + +static int silent_corruption_unwitting(void *data) +{ + u64 *local_ptr; + + pr_debug("starting %s\n", __func__); + + do { + local_ptr = READ_ONCE(g_corrupt_ptr); + do_something(0, 300); + } while (!local_ptr); + + local_ptr[0] = 0; + + return 0; +} + +static void silent_corruption_victim(int i) +{ + u64 local_var; + + pr_debug("starting %s %dth\n", __func__, i); + + /* local_var random in [0xff0000, 0x100ffff] */ + get_random_bytes(&local_var, sizeof(local_var)); + local_var = 0xff0000 + local_var & 0xffff; + + pr_debug("%s local_var addr: 0x%lx\n", __func__, + (unsigned long)&local_var); + + do_something(0, 100); + + if (local_var >= 0xff0000 && local_var <= 0xffffff) + pr_info("%s %d happy with 0x%llx\n", __func__, i, local_var); + else + pr_info("%s %d unhappy with 0x%llx\n", __func__, i, local_var); +} + +/* + * Test Case 2: Silent Corruption + * buggy() does not protect its local var correctly + * unwitting() simply does its intended work + * victim() is unaware know what happened + */ +static void silent_corruption_test(void) +{ + struct task_struct *unwitting; + + pr_info("starting %s\n", __func__); + WRITE_ONCE(g_corrupt_ptr, NULL); + + unwitting = kthread_run(silent_corruption_unwitting, NULL, "unwitting"); + if (IS_ERR(unwitting)) { + pr_err("failed to create thread2\n"); + return; + } + + silent_corruption_buggy(0); + for (int i = 0; i < 10; i++) + silent_corruption_victim(i); +} + static ssize_t test_proc_write(struct file *file, const char __user *buffer, size_t count, loff_t *pos) { @@ -88,6 +174,10 @@ static ssize_t test_proc_write(struct file *file, const char __user *buffer, pr_info("triggering canary overflow test\n"); canary_test_overflow(); break; + case 2: + pr_info("triggering silent corruption test\n"); + silent_corruption_test(); + break; default: pr_err("Unknown test number %d\n", test_num); return -EINVAL; @@ -108,7 +198,8 @@ static ssize_t test_proc_read(struct file *file, char __user *buffer, "==================================\n" "Usage:\n" " echo 'test0' > /proc/kstackwatch_test - Canary write test\n" - " echo 'test1' > /proc/kstackwatch_test - Canary overflow test\n"; + " echo 'test1' > /proc/kstackwatch_test - Canary overflow test\n" + " echo 'test2' > /proc/kstackwatch_test - Silent corruption test\n"; return simple_read_from_buffer(buffer, count, pos, usage, strlen(usage)); -- 2.43.0