From: Erick Karanja <karanja99erick@gmail.com>
To: broonie@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, julia.lawall@inria.fr,
Erick Karanja <karanja99erick@gmail.com>
Subject: [PATCH] spi: Convert lock/unlock to scoped_guard
Date: Wed, 10 Sep 2025 23:50:03 +0300 [thread overview]
Message-ID: <20250910205003.421067-1-karanja99erick@gmail.com> (raw)
Siplify the lock/unlock pattern with scope based cleanup.
Generated-by: Coccinelle SmPL
Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
---
drivers/spi/spi-qup.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index 7d647edf6bc3..ad4f526a3705 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -654,10 +654,10 @@ static irqreturn_t spi_qup_qup_irq(int irq, void *dev_id)
error = -EIO;
}
- spin_lock(&controller->lock);
- if (!controller->error)
- controller->error = error;
- spin_unlock(&controller->lock);
+ scoped_guard (spinlock, &controller->lock) {
+ if (!controller->error)
+ controller->error = error;
+ }
if (spi_qup_is_dma_xfer(controller->mode)) {
writel_relaxed(opflags, controller->base + QUP_OPERATIONAL);
--
2.43.0
next reply other threads:[~2025-09-10 20:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 20:50 Erick Karanja [this message]
2025-09-10 21:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250910205003.421067-1-karanja99erick@gmail.com \
--to=karanja99erick@gmail.com \
--cc=broonie@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®