From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
"Donald Hunter" <donald.hunter@gmail.com>,
"Simon Horman" <horms@kernel.org>,
"Jacob Keller" <jacob.e.keller@intel.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Sabrina Dubroca" <sd@queasysnail.net>,
wireguard@lists.zx2c4.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next v2 05/12] tools: ynl-gen: add CodeWriter.p_lines() helper
Date: Wed, 10 Sep 2025 23:08:27 +0000 [thread overview]
Message-ID: <20250910230841.384545-6-ast@fiberby.net> (raw)
In-Reply-To: <20250910230841.384545-1-ast@fiberby.net>
Add a helper for writing an array of lines, and convert
all the existing loops doing that, to use the new helper.
This is a trivial patch with no behavioural changes intended,
there are no changes to the generated code.
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
tools/net/ynl/pyynl/ynl_gen_c.py | 32 ++++++++++++++------------------
1 file changed, 14 insertions(+), 18 deletions(-)
diff --git a/tools/net/ynl/pyynl/ynl_gen_c.py b/tools/net/ynl/pyynl/ynl_gen_c.py
index 6441d5a31391..18c6ed0044b9 100755
--- a/tools/net/ynl/pyynl/ynl_gen_c.py
+++ b/tools/net/ynl/pyynl/ynl_gen_c.py
@@ -181,8 +181,7 @@ class Type(SpecAttr):
def free(self, ri, var, ref):
lines = self._free_lines(ri, var, ref)
- for line in lines:
- ri.cw.p(line)
+ ri.cw.p_lines(lines)
def arg_member(self, ri):
member = self._complex_member_type(ri)
@@ -268,13 +267,9 @@ class Type(SpecAttr):
if self.presence_type() == 'present':
ri.cw.p(f"{var}->_present.{self.c_name} = 1;")
- if init_lines:
- ri.cw.nl()
- for line in init_lines:
- ri.cw.p(line)
+ ri.cw.p_lines(init_lines, nl_before=True)
- for line in lines:
- ri.cw.p(line)
+ ri.cw.p_lines(lines)
ri.cw.block_end()
return True
@@ -1789,8 +1784,7 @@ class CodeWriter:
self.block_start()
self.write_func_lvar(local_vars=local_vars)
- for line in body:
- self.p(line)
+ self.p_lines(body)
self.block_end()
def writes_defines(self, defines):
@@ -1831,6 +1825,12 @@ class CodeWriter:
self.p('#ifdef ' + config_option)
self._ifdef_block = config_option
+ def p_lines(self, lines, nl_before=False):
+ if lines and nl_before:
+ self.nl()
+ for line in lines or []:
+ self.p(line)
+
scalars = {'u8', 'u16', 'u32', 'u64', 's8', 's16', 's32', 's64', 'uint', 'sint'}
@@ -2088,8 +2088,7 @@ def put_req_nested(ri, struct):
ri.cw.block_start()
ri.cw.write_func_lvar(local_vars)
- for line in init_lines:
- ri.cw.p(line)
+ ri.cw.p_lines(init_lines)
for _, arg in struct.member_list():
arg.attr_put(ri, "obj")
@@ -2150,8 +2149,7 @@ def _multi_parse(ri, struct, init_lines, local_vars):
ri.cw.block_start()
ri.cw.write_func_lvar(local_vars)
- for line in init_lines:
- ri.cw.p(line)
+ ri.cw.p_lines(init_lines)
ri.cw.nl()
for arg in struct.inherited:
@@ -2280,10 +2278,8 @@ def parse_rsp_submsg(ri, struct):
ri.cw.block_start(line=f'{kw} (!strcmp(sel, "{name}"))')
get_lines, init_lines, _ = arg._attr_get(ri, var)
- for line in init_lines or []:
- ri.cw.p(line)
- for line in get_lines:
- ri.cw.p(line)
+ ri.cw.p_lines(init_lines)
+ ri.cw.p_lines(get_lines)
if arg.presence_type() == 'present':
ri.cw.p(f"{var}->_present.{arg.c_name} = 1;")
ri.cw.block_end()
--
2.51.0
next prev parent reply other threads:[~2025-09-10 23:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 23:08 [PATCH net-next v2 00/12] tools: ynl: prepare for wireguard Asbjørn Sloth Tønnesen
2025-09-10 23:08 ` [PATCH net-next v2 01/12] tools: ynl-gen: allow overriding name-prefix for constants Asbjørn Sloth Tønnesen
2025-09-10 23:08 ` [PATCH net-next v2 02/12] tools: ynl-gen: generate nested array policies Asbjørn Sloth Tønnesen
2025-09-10 23:08 ` [PATCH net-next v2 03/12] tools: ynl-gen: add sub-type check Asbjørn Sloth Tønnesen
2025-09-10 23:08 ` [PATCH net-next v2 04/12] tools: ynl-gen: refactor local vars for .attr_put() callers Asbjørn Sloth Tønnesen
2025-09-10 23:08 ` Asbjørn Sloth Tønnesen [this message]
2025-09-11 10:47 ` [PATCH net-next v2 05/12] tools: ynl-gen: add CodeWriter.p_lines() helper Donald Hunter
2025-09-10 23:08 ` [PATCH net-next v2 06/12] tools: ynl-gen: deduplicate fixed_header handling Asbjørn Sloth Tønnesen
2025-09-10 23:08 ` [PATCH net-next v2 07/12] tools: ynl-gen: only validate nested array payload Asbjørn Sloth Tønnesen
2025-09-10 23:08 ` [PATCH net-next v2 08/12] tools: ynl-gen: rename TypeArrayNest to TypeIndexedArray Asbjørn Sloth Tønnesen
2025-09-10 23:08 ` [PATCH net-next v2 09/12] tools: ynl: move nest packing to a helper function Asbjørn Sloth Tønnesen
2025-09-10 23:08 ` [PATCH net-next v2 10/12] tools: ynl: encode indexed-arrays Asbjørn Sloth Tønnesen
2025-09-10 23:08 ` [PATCH net-next v2 11/12] tools: ynl: decode hex input Asbjørn Sloth Tønnesen
2025-09-10 23:08 ` [PATCH net-next v2 12/12] tools: ynl: add ipv4-or-v6 display hint Asbjørn Sloth Tønnesen
2025-09-11 1:29 ` [PATCH net-next v2 00/12] tools: ynl: prepare for wireguard Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250910230841.384545-6-ast@fiberby.net \
--to=ast@fiberby.net \
--cc=Jason@zx2c4.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®