mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: jbaron@akamai.com
Cc: gregkh@linuxfoundation.org, ukaszb@chromium.org,
	louis.chauvet@bootlin.com, linux-kernel@vger.kernel.org,
	Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 04/30] dyndbg: reword "class unknown," to "class:_UNKNOWN_"
Date: Thu, 11 Sep 2025 15:37:57 -0600	[thread overview]
Message-ID: <20250911213823.374806-5-jim.cromie@gmail.com> (raw)
In-Reply-To: <20250911213823.374806-1-jim.cromie@gmail.com>

When a dyndbg classname is unknown to a kernel module (as before
previous patch), the callsite is un-addressable via >control queries.

The control-file displays this condition as "class unknown,"
currently.  That spelling is sub-optimal/too-generic, so change it to
"class:_UNKNOWN_" to loudly announce the erroneous situation, and to
make it uniquely greppable.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
 lib/dynamic_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 5a007952f7f2..147540c57154 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1154,7 +1154,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p)
 		if (class)
 			seq_printf(m, " class:%s", class);
 		else
-			seq_printf(m, " class unknown, _id:%d", dp->class_id);
+			seq_printf(m, " class:_UNKNOWN_ _id:%d", dp->class_id);
 	}
 	seq_putc(m, '\n');
 
-- 
2.51.0


  parent reply	other threads:[~2025-09-11 21:38 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11 21:37 [PATCH 00/30] dyndbg: Rework classmap API to fix module dependency issues Jim Cromie
2025-09-11 21:37 ` [PATCH 01/30] docs/dyndbg: update examples \012 to \n Jim Cromie
2025-09-11 21:37 ` [PATCH 02/30] docs/dyndbg: explain flags parse 1st Jim Cromie
2025-09-11 21:37 ` [PATCH 03/30] test-dyndbg: fixup CLASSMAP usage error Jim Cromie
2025-09-11 21:37 ` Jim Cromie [this message]
2025-09-11 21:37 ` [PATCH 05/30] dyndbg: make ddebug_class_param union members same size Jim Cromie
2025-09-11 21:37 ` [PATCH 06/30] dyndbg: drop NUM_TYPE_ARRAY Jim Cromie
2025-09-11 21:38 ` [PATCH 07/30] dyndbg: tweak pr_fmt to avoid expansion conflicts Jim Cromie
2025-09-11 21:38 ` [PATCH 08/30] dyndbg: reduce verbose/debug clutter Jim Cromie
2025-09-11 21:38 ` [PATCH 09/30] dyndbg: refactor param_set_dyndbg_classes and below Jim Cromie
2025-09-11 21:38 ` [PATCH 10/30] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie
2025-09-11 21:38 ` [PATCH 11/30] dyndbg: replace classmap list with a vector Jim Cromie
2025-09-11 21:38 ` [PATCH 12/30] dyndbg: macrofy a 2-index for-loop pattern Jim Cromie
2025-09-11 21:38 ` [PATCH 13/30] dyndbg: DECLARE_DYNDBG_CLASSMAP needs stub defn Jim Cromie
2025-09-11 21:38 ` [PATCH 14/30] dyndbg,module: make proper substructs in _ddebug_info Jim Cromie
2025-09-11 21:38 ` [PATCH 15/30] dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module Jim Cromie
2025-09-11 21:38 ` [PATCH 16/30] dyndbg: move mod_name from ddebug_table down to _ddebug_info Jim Cromie
2025-09-11 21:38 ` [PATCH 17/30] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie
2025-09-11 21:38 ` [PATCH 18/30] selftests-dyndbg: add a dynamic_debug run_tests target Jim Cromie
2025-09-11 21:38 ` [PATCH 19/30] dyndbg: change __dynamic_func_call_cls* macros into expressions Jim Cromie
2025-09-11 21:38 ` [PATCH 20/30] dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP Jim Cromie
2025-09-11 21:38 ` [PATCH 21/30] dyndbg: detect class_id reservation conflicts Jim Cromie
2025-09-11 21:38 ` [PATCH 22/30] dyndbg: check DYNAMIC_DEBUG_CLASSMAP_DEFINE args at compile-time Jim Cromie
2025-09-11 21:38 ` [PATCH 23/30] dyndbg-test: change do_prints testpoint to accept a loopct Jim Cromie
2025-09-11 21:38 ` [PATCH 24/30] dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API Jim Cromie
2025-09-11 21:38 ` [PATCH 25/30] dyndbg: treat comma as a token separator Jim Cromie
2025-09-11 21:38 ` [PATCH 26/30] dyndbg: split multi-query strings with % Jim Cromie
2025-09-11 21:38 ` [PATCH 27/30] selftests-dyndbg: add test_mod_submod Jim Cromie
2025-09-11 21:38 ` [PATCH 28/30] dyndbg: resolve "protection" of class'd pr_debugs Jim Cromie
2025-09-11 21:38 ` [PATCH 29/30] dyndbg: add DYNAMIC_DEBUG_CLASSMAP_USE_(clname,_base) Jim Cromie
2025-09-11 21:38 ` [PATCH 30/30] docs/dyndbg: add classmap info to howto Jim Cromie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250911213823.374806-5-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbaron@akamai.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=ukaszb@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®