From: John Ripple <john.ripple@keysight.com>
To: dianders@chromium.org
Cc: Laurent.pinchart@ideasonboard.com, airlied@gmail.com,
andrzej.hajda@intel.com, blake.vermeer@keysight.com,
dri-devel@lists.freedesktop.org, jernej.skrabec@gmail.com,
john.ripple@keysight.com, jonas@kwiboo.se,
linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com,
matt_laubhan@keysight.com, mripard@kernel.org,
neil.armstrong@linaro.org, rfoss@kernel.org, simona@ffwll.ch,
tzimmermann@suse.de
Subject: Re: [PATCH V3] drm/bridge: ti-sn65dsi86: Add support for DisplayPort mode with HPD
Date: Fri, 12 Sep 2025 13:23:56 -0600 [thread overview]
Message-ID: <20250912192356.2067099-1-john.ripple@keysight.com> (raw)
In-Reply-To: <CAD=FV=WkbQeCaqHL3A3RzW9GhiLvkrZEbfLUFwfnx4LJQbUcWg@mail.gmail.com>
Hi,
>As I said, maybe the problem is fixed now, but at the same time there
>is something nice about the interrupt type only being specified in one
>place. ...and IIRC the device tree validator gets upset if you don't
>specify the interrupt type there, so removing it from the source code
>seems nice...
My device tree does have interrupts already specified for the node,
so allowing the driver to use that does seem like a good idea.
> [1] https://stackoverflow.com/questions/40011799/mapping-device-tree-interrupt-flags-to-devm-request-irq
The link you sent suggests just using "0" for the flag value lets the
device tree flags to be used. I couldn't do this because the
IRQF_ONESHOT needed to be passed as a flag or I'd get stack traces
every time the irq was triggered. Several of the other drivers in
drivers/gpu/drm/bridge only pass IRQ_ONESHOT so I think those might be
using the device tree flags with the oneshot flag. As far as I could
tell, only passing the oneshot flag and setting the interrupt level
high in the device tree works.
next prev parent reply other threads:[~2025-09-12 19:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 15:24 [PATCH 1/2] " John Ripple
2025-08-20 15:24 ` [PATCH 2/2] drm/bridge: ti-sn65dsi86: break probe dependency loop John Ripple
2025-08-29 16:40 ` Doug Anderson
2025-09-01 7:00 ` Maxime Ripard
2025-09-02 16:22 ` John Ripple
2025-09-02 17:26 ` Doug Anderson
2025-08-29 16:40 ` [PATCH 1/2] drm/bridge: ti-sn65dsi86: Add support for DisplayPort mode with HPD Doug Anderson
2025-09-08 20:36 ` [PATCH V2] " John Ripple
2025-09-09 0:11 ` Doug Anderson
2025-09-09 19:36 ` John Ripple
2025-09-09 22:44 ` Doug Anderson
2025-09-10 18:33 ` [PATCH V3] " John Ripple
2025-09-10 20:48 ` Doug Anderson
2025-09-11 18:39 ` John Ripple
2025-09-11 23:25 ` Doug Anderson
2025-09-12 19:23 ` John Ripple [this message]
2025-09-12 19:24 ` [PATCH V4] " John Ripple
2025-09-12 20:02 ` Doug Anderson
2025-09-12 21:08 ` [PATCH V5] " John Ripple
2025-09-12 21:27 ` Doug Anderson
2025-09-15 16:50 ` [PATCH V6] " John Ripple
2025-09-15 17:33 ` Doug Anderson
2025-09-15 17:47 ` [PATCH V3] " John Ripple
2025-09-15 17:45 ` [PATCH V7] " John Ripple
2025-09-15 17:57 ` Doug Anderson
2025-09-23 15:23 ` Doug Anderson
2025-09-16 5:46 ` [PATCH V3] " Dan Carpenter
2025-09-16 14:30 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250912192356.2067099-1-john.ripple@keysight.com \
--to=john.ripple@keysight.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=blake.vermeer@keysight.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matt_laubhan@keysight.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®