From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Wake Liu <wakel@google.com>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>, "Shuah Khan" <shuah@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Darren Hart" <dvhart@infradead.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"André Almeida" <andrealmeid@igalia.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/futex: Conditionally run futex_numa_mpol test
Date: Fri, 12 Sep 2025 23:44:54 +0200 [thread overview]
Message-ID: <20250912214454.t0qhEqT2@linutronix.de> (raw)
In-Reply-To: <20250908113721.4031242-1-wakel@google.com>
On 2025-09-08 19:37:20 [+0800], Wake Liu wrote:
> The futex_numa_mpol test requires libnuma, which is not available on
> all platforms. When the test is not built, the run.sh script fails
> because it unconditionally tries to execute the test binary.
>
> Check for the futex_numa_mpol executable before running it. If the
> binary is not present, print a skip message and continue.
>
> This allows the test suite to run successfully on platforms that do
> not have libnuma and therefore do not build the futex_numa_mpol
> test.
If you skip the test, how to you compile this?
Does
https://lore.kernel.org/all/20250818135458.F352St6W@linutronix.de/
help?
> Signed-off-by: Wake Liu <wakel@google.com>
> ---
> tools/testing/selftests/futex/functional/run.sh | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/futex/functional/run.sh b/tools/testing/selftests/futex/functional/run.sh
> index 81739849f299..f3e43eb806bf 100755
> --- a/tools/testing/selftests/futex/functional/run.sh
> +++ b/tools/testing/selftests/futex/functional/run.sh
> @@ -88,4 +88,8 @@ echo
> ./futex_priv_hash -g $COLOR
>
> echo
> -./futex_numa_mpol $COLOR
> +if [ -x ./futex_numa_mpol ]; then
> + ./futex_numa_mpol $COLOR
> +else
> + echo "SKIP: futex_numa_mpol (not built)"
> +fi
Sebastian
prev parent reply other threads:[~2025-09-12 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 11:37 Wake Liu
2025-09-12 19:49 ` André Almeida
2025-09-12 21:44 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250912214454.t0qhEqT2@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=andrealmeid@igalia.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=wakel@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®