From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEEC663CF; Sat, 13 Sep 2025 14:06:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757772417; cv=none; b=SmaLRv1jxEhsU0ZIrBeaxRfk1fBBiZ4mY/a83t7IMANvgbPc5lLrveKBIwmBZCdbS9q7EeVHIjN0Vc0lHZlkJZC2BS6O3Jx4w8tIjsLu0ouUmDS2HWkKIikKfLdy1hsWr2NuwMsRnyCl9h3zVq+DPpQbLRomlUCLAyMU/nD2Cr4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757772417; c=relaxed/simple; bh=h/aHcUcrLTnTYI0mLM9B2w4gQ26lylTJYxKCXczLBqw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H71XIlH3tLUDctStBPK+70qbj2k+q5TQAJRKMZ0a7tNkJvKUZilc0csRJKlbl2qP7tRRaWtr46vegQcQ2PaZCXb7zYG4+cpYOHEgeGR41wCTKZTSipHwM8Jd2xFBYIJw3mDQKM5LNB2WWTfAFm0tTpXXW/re6sk64pYVdqxa27U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=srvrJTxS; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="srvrJTxS" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id DBFC3E91; Sat, 13 Sep 2025 16:05:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1757772338; bh=h/aHcUcrLTnTYI0mLM9B2w4gQ26lylTJYxKCXczLBqw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=srvrJTxSgKt2fLOTbQWRv9AsCT+HONmZzHpImt5H0LZoxpGI5vofSRC40SgEFhhp+ xL5zhhMTLA2E27f8BK9NdjyPN4X7yoavLgVULi8Y1jHmBO/yBYI4XpMPpMw/KUdq3f Q7QHhWck3dw2DxeZfZZqAasWWhJ0v4iMkkvqyik4= Date: Sat, 13 Sep 2025 17:06:28 +0300 From: Laurent Pinchart To: Ricardo Ribalda Cc: Hans de Goede , Mauro Carvalho Chehab , Hans Verkuil , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 4/4] media: uvcvideo: Support UVC_CROSXU_CONTROL_IQ_PROFILE Message-ID: <20250913140628.GB10328@pendragon.ideasonboard.com> References: <20250818-uvc-iq-switch-v1-0-f7ea5e740ddd@chromium.org> <20250818-uvc-iq-switch-v1-4-f7ea5e740ddd@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250818-uvc-iq-switch-v1-4-f7ea5e740ddd@chromium.org> On Mon, Aug 18, 2025 at 08:15:39PM +0000, Ricardo Ribalda wrote: > The ChromeOS XU provides a control to change the IQ profile for a camera. > It can be switched from VIVID (a.k.a. standard) to NONE (a.k.a. natural). > > Wire it up to the standard v4l2 control. > > Signed-off-by: Ricardo Ribalda > --- > drivers/media/usb/uvc/uvc_ctrl.c | 32 ++++++++++++++++++++++++++++++++ > include/linux/usb/uvc.h | 5 +++++ > 2 files changed, 37 insertions(+) > > diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c > index ff975f96e1325532e2299047c07de5d1b9cf09db..8766a441ad1d8554c0daaed3f87758321684246b 100644 > --- a/drivers/media/usb/uvc/uvc_ctrl.c > +++ b/drivers/media/usb/uvc/uvc_ctrl.c > @@ -376,6 +376,15 @@ static const struct uvc_control_info uvc_ctrls[] = { > | UVC_CTRL_FLAG_GET_DEF > | UVC_CTRL_FLAG_AUTO_UPDATE, > }, > + { > + .entity = UVC_GUID_CHROMEOS_XU, > + .selector = UVC_CROSXU_CONTROL_IQ_PROFILE, > + .index = 3, > + .size = 1, > + .flags = UVC_CTRL_FLAG_SET_CUR > + | UVC_CTRL_FLAG_GET_RANGE > + | UVC_CTRL_FLAG_RESTORE, > + }, > }; > > static const u32 uvc_control_classes[] = { > @@ -384,6 +393,17 @@ static const u32 uvc_control_classes[] = { > }; > > static const int exposure_auto_mapping[] = { 2, 1, 4, 8 }; > +static const int cros_colorfx_mapping[] = { 1, // V4L2_COLORFX_NONE > + -1, // V4L2_COLORFX_BW > + -1, // V4L2_COLORFX_SEPIA > + -1, // V4L2_COLORFX_NEGATIVE > + -1, // V4L2_COLORFX_EMBOSS > + -1, // V4L2_COLORFX_SKETCH > + -1, // V4L2_COLORFX_SKY_BLUE > + -1, // V4L2_COLORFX_GRASS_GREEN > + -1, // V4L2_COLORFX_SKIN_WHITEN > + 0}; // V4L2_COLORFX_VIVID}; Extar '};' at the end of the line. The indentation also looks a bit weird. I'll replace it with static const int cros_colorfx_mapping[] = { 1, /* V4L2_COLORFX_NONE */ -1, /* V4L2_COLORFX_BW */ -1, /* V4L2_COLORFX_SEPIA */ -1, /* V4L2_COLORFX_NEGATIVE */ -1, /* V4L2_COLORFX_EMBOSS */ -1, /* V4L2_COLORFX_SKETCH */ -1, /* V4L2_COLORFX_SKY_BLUE */ -1, /* V4L2_COLORFX_GRASS_GREEN */ -1, /* V4L2_COLORFX_SKIN_WHITEN */ 0, /* V4L2_COLORFX_VIVID */ }; > + > > static bool uvc_ctrl_mapping_is_compound(struct uvc_control_mapping *mapping) > { > @@ -975,6 +995,18 @@ static const struct uvc_control_mapping uvc_ctrl_mappings[] = { > .data_type = UVC_CTRL_DATA_TYPE_BITMASK, > .name = "Region of Interest Auto Ctrls", > }, > + { > + .id = V4L2_CID_COLORFX, > + .entity = UVC_GUID_CHROMEOS_XU, > + .selector = UVC_CROSXU_CONTROL_IQ_PROFILE, > + .size = 8, > + .offset = 0, > + .v4l2_type = V4L2_CTRL_TYPE_MENU, > + .data_type = UVC_CTRL_DATA_TYPE_ENUM, > + .menu_mapping = cros_colorfx_mapping, > + .menu_mask = BIT(V4L2_COLORFX_VIVID) | > + BIT(V4L2_COLORFX_NONE), > + }, > }; > > /* ------------------------------------------------------------------------ > diff --git a/include/linux/usb/uvc.h b/include/linux/usb/uvc.h > index 12a57e1d34674a3a264ed7f88bed43926661fcd4..22e0dab0809e296e089940620ae0e8838e109701 100644 > --- a/include/linux/usb/uvc.h > +++ b/include/linux/usb/uvc.h > @@ -29,6 +29,9 @@ > #define UVC_GUID_EXT_GPIO_CONTROLLER \ > {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \ > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x03} > +#define UVC_GUID_CHROMEOS_XU \ > + {0x24, 0xe9, 0xd7, 0x74, 0xc9, 0x49, 0x45, 0x4a, \ > + 0x98, 0xa3, 0xc8, 0x07, 0x7e, 0x05, 0x1c, 0xa3} I'd like to add a link to the documentation, but searching for the GUID didn't turn up any meaningful result. Where can I find documentation for this XU ? The link can be added later, so Reviewed-by: Laurent Pinchart > #define UVC_GUID_MSXU_1_5 \ > {0xdc, 0x95, 0x3f, 0x0f, 0x32, 0x26, 0x4e, 0x4c, \ > 0x92, 0xc9, 0xa0, 0x47, 0x82, 0xf4, 0x3b, 0xc8} > @@ -50,6 +53,8 @@ > #define UVC_MSXU_CONTROL_FIELDOFVIEW2_CONFIG 0x0f > #define UVC_MSXU_CONTROL_FIELDOFVIEW2 0x10 > > +#define UVC_CROSXU_CONTROL_IQ_PROFILE 0x04 > + > #define UVC_GUID_FORMAT_MJPEG \ > { 'M', 'J', 'P', 'G', 0x00, 0x00, 0x10, 0x00, \ > 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} -- Regards, Laurent Pinchart