mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: wangyufei <wangyufei@vivo.com>
To: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
	cem@kernel.org
Cc: kundan.kumar@samsung.com, anuj20.g@samsung.com, hch@lst.de,
	bernd@bsbernd.com, djwong@kernel.org, david@fromorbit.com,
	linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, opensource.kernel@vivo.com,
	wangyufei <wangyufei@vivo.com>
Subject: [RFC 2/2] xfs: implement get_inode_wb_ctx_idx() for per-AG parallel writeback
Date: Sun, 14 Sep 2025 20:11:09 +0800	[thread overview]
Message-ID: <20250914121109.36403-3-wangyufei@vivo.com> (raw)
In-Reply-To: <20250914121109.36403-1-wangyufei@vivo.com>

The number of writeback contexts is set to the number of CPUs by
default. This allows XFS to decide how to assign inodes to writeback
contexts based on its allocation groups.

Implement get_inode_wb_ctx_idx() in xfs_super_operations as follows:
- Limit the number of active writeback contexts to the number of AGs.
- Assign inodes from the same AG to a unique writeback context.

Signed-off-by: wangyufei <wangyufei@vivo.com>
---
 fs/xfs/xfs_super.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 77acb3e5a..156df0397 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1279,6 +1279,19 @@ xfs_fs_show_stats(
 	return 0;
 }
 
+static unsigned int
+xfs_fs_get_inode_wb_ctx_idx(
+	struct inode		*inode,
+	int			nr_wb_ctx)
+{
+	struct xfs_inode *xfs_inode = XFS_I(inode);
+	struct xfs_mount *mp = XFS_M(inode->i_sb);
+
+	if (mp->m_sb.sb_agcount <= nr_wb_ctx)
+		return XFS_INO_TO_AGNO(mp, xfs_inode->i_ino);
+	return xfs_inode->i_ino % nr_wb_ctx;
+}
+
 static const struct super_operations xfs_super_operations = {
 	.alloc_inode		= xfs_fs_alloc_inode,
 	.destroy_inode		= xfs_fs_destroy_inode,
@@ -1295,6 +1308,7 @@ static const struct super_operations xfs_super_operations = {
 	.free_cached_objects	= xfs_fs_free_cached_objects,
 	.shutdown		= xfs_fs_shutdown,
 	.show_stats		= xfs_fs_show_stats,
+	.get_inode_wb_ctx_idx   = xfs_fs_get_inode_wb_ctx_idx,
 };
 
 static int
-- 
2.34.1


  parent reply	other threads:[~2025-09-14 12:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-14 12:11 [RFC 0/2] writeback: add support for filesystems to optimize " wangyufei
2025-09-14 12:11 ` [RFC 1/2] writeback: add support for filesystems to affine inodes to specific writeback ctx wangyufei
2025-09-14 12:11 ` wangyufei [this message]
2025-09-22 16:56   ` [RFC 2/2] xfs: implement get_inode_wb_ctx_idx() for per-AG parallel writeback Christoph Hellwig
2025-09-23 18:46     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250914121109.36403-3-wangyufei@vivo.com \
    --to=wangyufei@vivo.com \
    --cc=anuj20.g@samsung.com \
    --cc=bernd@bsbernd.com \
    --cc=brauner@kernel.org \
    --cc=cem@kernel.org \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=kundan.kumar@samsung.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=opensource.kernel@vivo.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®