Re: [PATCH v3 3/4] clk: mmp: pxa1908: Instantiate power driver through auxiliary bus

[Peng Fan <peng.fan@oss.nxp.com>]

On Fri, Aug 29, 2025 at 06:21:06PM +0200, Duje Mihanovi?? wrote:
>The power domain driver shares the APMU clock controller's registers.
>Instantiate the power domain driver through the APMU clock driver using
>the auxiliary bus.
>
>Also create a separate Kconfig entry for the PXA1908 clock driver to
>allow (de)selecting the driver at will and selecting
>CONFIG_AUXILIARY_BUS.
>
>Signed-off-by: Duje Mihanovi?? <duje@dujemihanovic.xyz>
>---
>v3:
>- Move driver back to pmdomain subsystem, use auxiliary bus to
>  instantiate the driver
>
>v2:
>- Move to clk subsystem, instantiate the driver from the APMU clock
>  driver
>- Drop clock handling
>- Squash MAINTAINERS patch
>---
> MAINTAINERS                        |  2 ++
> drivers/clk/Kconfig                |  1 +
> drivers/clk/mmp/Kconfig            | 10 ++++++++++
> drivers/clk/mmp/Makefile           |  5 ++++-
> drivers/clk/mmp/clk-pxa1908-apmu.c | 20 ++++++++++++++++++++
> 5 files changed, 37 insertions(+), 1 deletion(-)
>
>diff --git a/MAINTAINERS b/MAINTAINERS
>index 34e5e218e83e0ed9882b111f5251601dd6549d4e..88c0df09d7b354f95864f5a48daea3be14a90dc4 100644
>--- a/MAINTAINERS
>+++ b/MAINTAINERS
>@@ -2869,7 +2869,9 @@ ARM/Marvell PXA1908 SOC support
> M:	Duje Mihanovi?? <duje@dujemihanovic.xyz>
> L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> S:	Maintained
>+F:	Documentation/devicetree/bindings/clock/marvell,pxa1908.yaml
> F:	arch/arm64/boot/dts/marvell/mmp/
>+F:	drivers/clk/mmp/Kconfig
> F:	drivers/clk/mmp/clk-pxa1908*.c
> F:	drivers/pmdomain/marvell/
> F:	include/dt-bindings/clock/marvell,pxa1908.h
>diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
>index 4d56475f94fc1e28823fe6aee626a96847d4e6d5..68a9641fc649a23013b2d8a9e9f5ecb31d623abb 100644
>--- a/drivers/clk/Kconfig
>+++ b/drivers/clk/Kconfig
>@@ -511,6 +511,7 @@ source "drivers/clk/imx/Kconfig"
> source "drivers/clk/ingenic/Kconfig"
> source "drivers/clk/keystone/Kconfig"
> source "drivers/clk/mediatek/Kconfig"
>+source "drivers/clk/mmp/Kconfig"
> source "drivers/clk/meson/Kconfig"
> source "drivers/clk/mstar/Kconfig"
> source "drivers/clk/microchip/Kconfig"
>diff --git a/drivers/clk/mmp/Kconfig b/drivers/clk/mmp/Kconfig
>new file mode 100644
>index 0000000000000000000000000000000000000000..b0d2fea3cda5de1284916ab75d3af0412edcf57f
>--- /dev/null
>+++ b/drivers/clk/mmp/Kconfig
>@@ -0,0 +1,10 @@
>+# SPDX-License-Identifier: GPL-2.0-only
>+
>+config COMMON_CLK_PXA1908
>+	bool "Clock driver for Marvell PXA1908"

tristate for module built.

Regards
Peng