From: Peng Fan <peng.fan@oss.nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 5/5] clk: samsung: introduce exynos8890 clock driver
Date: Mon, 15 Sep 2025 19:30:55 +0800 [thread overview]
Message-ID: <20250915113055.GA14420@nxa18884-linux.ap.freescale.net> (raw)
In-Reply-To: <83128929-4daa-4dac-8162-e773af675438@kernel.org>
On Mon, Sep 15, 2025 at 09:16:40AM +0200, Krzysztof Kozlowski wrote:
>On 15/09/2025 09:49, Peng Fan wrote:
>> [...]
>>> +static void __init exynos8890_cmu_top_init(struct device_node *np)
>>> +{
>>> + exynos8890_init_clocks(np, &top_cmu_info);
>>> + samsung_cmu_register_one(np, &top_cmu_info);
>>> +}
>>> +
>>> +/* Register CMU_TOP early, as it's a dependency for other early domains */
>>> +CLK_OF_DECLARE(exynos8890_cmu_top, "samsung,exynos8890-cmu-top",
>>> + exynos8890_cmu_top_init);
>>
>> Not sure you need to run Android GKI, without module built, this platform
>> will not able to support GKI.
>
>Why would anyone worry about GKI? We develop mainline kernel, not
>Android kernel.
I understand this. But someone will have to update this to support module
built whether mainline or downstream tree, unless GKI is not in the plan.
>
>This seems to be aligned with existing approach, no? What is different here?
No objection from me. I just think supporting module built is a better method.
Regards,
Peng
>
>Best regards,
>Krzysztof
>
next prev parent reply other threads:[~2025-09-15 10:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-14 12:21 [PATCH v1 0/5] " Ivaylo Ivanov
2025-09-14 12:21 ` [PATCH v1 1/5] dt-bindings: clock: add exynos8890 SoC Ivaylo Ivanov
2025-09-14 12:21 ` [PATCH v1 2/5] clk: samsung: clk-pll: Add support for pll_141xx Ivaylo Ivanov
2025-09-15 7:24 ` Peng Fan
2025-09-14 12:21 ` [PATCH v1 3/5] clk: samsung: clk-pll: Add support for pll_1419x Ivaylo Ivanov
2025-09-15 7:26 ` Peng Fan
2025-09-14 12:21 ` [PATCH v1 4/5] clk: samsung: clk-pll: Add support for pll_1431x Ivaylo Ivanov
2025-09-15 7:27 ` Peng Fan
2025-09-14 12:21 ` [PATCH v1 5/5] clk: samsung: introduce exynos8890 clock driver Ivaylo Ivanov
2025-09-14 14:16 ` kernel test robot
2025-09-15 7:49 ` Peng Fan
2025-09-15 7:16 ` Krzysztof Kozlowski
2025-09-15 11:30 ` Peng Fan [this message]
2025-09-17 2:26 ` Krzysztof Kozlowski
2025-09-15 8:59 ` Ivaylo Ivanov
2025-09-15 11:44 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915113055.GA14420@nxa18884-linux.ap.freescale.net \
--to=peng.fan@oss.nxp.com \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®