From: Gabriele Monaco <gmonaco@redhat.com>
To: linux-kernel@vger.kernel.org, Yury Norov <yury.norov@gmail.com>
Cc: Gabriele Monaco <gmonaco@redhat.com>
Subject: [PATCH v12 8/9] cpumask: Add initialiser CPUMASK_NULL to use cleanup helpers
Date: Mon, 15 Sep 2025 16:59:29 +0200 [thread overview]
Message-ID: <20250915145920.140180-19-gmonaco@redhat.com> (raw)
In-Reply-To: <20250915145920.140180-11-gmonaco@redhat.com>
The cleanup helper __free(free_cpumask_var) works only if the function
returns after alloc_cpumask_var, this can complicate the code in case
there are multiple cpumasks using the cleanup helper.
Define a cpumask initialiser that is NULL if the cpumask is a pointer
and {} if it's on stack. This allows users of the cleanup helper to use
it freely on initialised cpumasks as the actual free will be called only
if the mask is not NULL (and of course if it's a pointer).
This solution was first used in [1], dropped as eventually a single mask
was sufficient.
[1] - https://lore.kernel.org/lkml/20240120025053.684838-8-yury.norov@gmail.com
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
include/linux/cpumask.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h
index ff8f41ab7ce6..5fb9c3fe4256 100644
--- a/include/linux/cpumask.h
+++ b/include/linux/cpumask.h
@@ -1005,6 +1005,7 @@ static __always_inline unsigned int cpumask_size(void)
#define this_cpu_cpumask_var_ptr(x) this_cpu_read(x)
#define __cpumask_var_read_mostly __read_mostly
+#define CPUMASK_NULL NULL
bool alloc_cpumask_var_node(cpumask_var_t *mask, gfp_t flags, int node);
@@ -1051,6 +1052,7 @@ static __always_inline bool cpumask_available(cpumask_var_t mask)
#define this_cpu_cpumask_var_ptr(x) this_cpu_ptr(x)
#define __cpumask_var_read_mostly
+#define CPUMASK_NULL {}
static __always_inline bool alloc_cpumask_var(cpumask_var_t *mask, gfp_t flags)
{
--
2.51.0
next prev parent reply other threads:[~2025-09-15 15:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 14:59 [PATCH v12 0/9] timers: Exclude isolated cpus from timer migration Gabriele Monaco
2025-09-15 14:59 ` [PATCH v12 1/9] timers/migration: Postpone online/offline callbacks registration to late initcall Gabriele Monaco
2025-09-15 14:59 ` [PATCH v12 2/9] timers: Rename tmigr 'online' bit to 'available' Gabriele Monaco
2025-09-15 14:59 ` [PATCH v12 3/9] timers: Add the available mask in timer migration Gabriele Monaco
2025-09-15 14:59 ` [PATCH v12 4/9] timers: Use scoped_guard when setting/clearing the tmigr available flag Gabriele Monaco
2025-09-15 14:59 ` [PATCH v12 5/9] cgroup/cpuset: Rename update_unbound_workqueue_cpumask() to update_exclusion_cpumasks() Gabriele Monaco
2025-09-15 14:59 ` [PATCH v12 6/9] sched/isolation: Force housekeeping if isolcpus and nohz_full don't leave any Gabriele Monaco
2025-09-15 14:59 ` [PATCH v12 7/9] cgroup/cpuset: Fail if isolated and nohz_full don't leave any housekeeping Gabriele Monaco
2025-09-15 20:43 ` Waiman Long
2025-09-16 8:31 ` Chen Ridong
2025-09-15 14:59 ` Gabriele Monaco [this message]
2025-09-15 16:04 ` [PATCH v12 8/9] cpumask: Add initialiser CPUMASK_NULL to use cleanup helpers Yury Norov
2025-09-15 17:02 ` Gabriele Monaco
2025-09-15 18:35 ` Yury Norov
2025-09-16 11:27 ` Frederic Weisbecker
2025-09-17 7:51 ` Gabriele Monaco
2025-09-17 11:38 ` Yury Norov
2025-09-17 12:08 ` Gabriele Monaco
2025-09-17 12:34 ` Yury Norov
2025-09-19 14:58 ` Yury Norov
2025-09-22 10:07 ` Gabriele Monaco
2025-09-15 14:59 ` [PATCH v12 9/9] timers: Exclude isolated cpus from timer migration Gabriele Monaco
2025-09-15 20:51 ` John B. Wyatt IV
2025-09-16 5:29 ` Gabriele Monaco
2025-09-16 13:41 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915145920.140180-19-gmonaco@redhat.com \
--to=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®