From: Fiona Ebner <f.ebner@proxmox.com>
To: linux-kernel@vger.kernel.org
Cc: samba-technical@lists.samba.org, linux-cifs@vger.kernel.org,
bharathsm@microsoft.com, tom@talpey.com, sprasad@microsoft.com,
ronniesahlberg@gmail.com, pc@manguebit.org, sfrench@samba.org
Subject: [PATCH 0/2] smb: client: transport: avoid reconnects triggered by pending task work
Date: Mon, 15 Sep 2025 17:19:38 +0200 [thread overview]
Message-ID: <20250915151950.1017597-1-f.ebner@proxmox.com> (raw)
When io_uring is used in the same task as CIFS, there might be
unnecessary reconnects, causing issues in user-space applications
like QEMU with a log like:
> CIFS: VFS: \\10.10.100.81 Error -512 sending data on socket to server
Certain io_uring completions might be added to task_work with
notify_method being TWA_SIGNAL and thus TIF_NOTIFY_SIGNAL is set for
the task.
In __smb_send_rqst(), signals are masked before calling
smb_send_kvec(), but the masking does not apply to TIF_NOTIFY_SIGNAL.
If sk_stream_wait_memory() is reached via sock_sendmsg() while
TIF_NOTIFY_SIGNAL is set, signal_pending(current) will evaluate to
true there, and -EINTR will be propagated all the way from
sk_stream_wait_memory() to sock_sendmsg() in smb_send_kvec().
Afterwards, __smb_send_rqst() will see that not everything was written
and reconnect.
A reproducer exposing the issue using QEMU:
#!/bin/bash
target=$1
dd if=/dev/urandom of=/tmp/disk.raw bs=1M count=100
qemu-img create -f raw $target 100M
./qemu-system-x86_64 --qmp stdio \
--blockdev raw,node-name=node0,file.driver=file,file.filename=/tmp/disk.raw,file.aio=io_uring \
--blockdev raw,node-name=node1,file.driver=file,file.filename=$target,file.aio=native,file.cache.direct=on \
<<EOF
{"execute": "qmp_capabilities"}
{"execute": "blockdev-mirror", "arguments": { "job-id": "mirror0", "device": "node0", "target": "node1", "sync": "full" } }
EOF
Another reproducer is having a QEMU virtual machine with one disk
using io_uring and one disk on CIFS and doing IO to both disks at the
same time.
I also got a reproducer based on liburing's examples/io_uring-cp.c
which I can send along if you are interested in it.
Fiona Ebner (2):
smb: client: transport: avoid reconnects triggered by pending task
work
smb: client: transport: minor indentation style fix
fs/smb/client/transport.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
--
2.47.2
next reply other threads:[~2025-09-15 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 15:19 Fiona Ebner [this message]
2025-09-15 15:19 ` [PATCH 1/2] " Fiona Ebner
2025-10-02 3:19 ` Steve French
2025-09-15 15:19 ` [PATCH 2/2] smb: client: transport: minor indentation style fix Fiona Ebner
2025-09-30 14:08 ` [PATCH 0/2] smb: client: transport: avoid reconnects triggered by pending task work Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915151950.1017597-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=bharathsm@microsoft.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®