From: Avadhut Naik <avadhut.naik@amd.com>
To: <linux-edac@vger.kernel.org>
Cc: <bp@alien8.de>, <yazen.ghannam@amd.com>, <john.allen@amd.com>,
<linux-kernel@vger.kernel.org>, <avadnaik@amd.com>
Subject: [PATCH v2 0/2] Incorporate DRAM address in EDAC messages
Date: Mon, 15 Sep 2025 21:20:21 +0000 [thread overview]
Message-ID: <20250915212244.886668-1-avadhut.naik@amd.com> (raw)
Currently, the amd64_edac module only provides UMC normalized and system
physical address when a DRAM ECC error occurs. DRAM Address is neither
logged nor exported through tracepoint.
Modern AMD SOCs provide UEFI PRM module that implements various address
translation PRM handlers. These PRM handlers can be leveraged to convert
UMC normalized address into DRAM address at runtime on occurrence of a
DRAM ECC error. This translated DRAM address can then be logged and
exported through tracepoints. This set adds the required support to
accomplish the aforementioned.
The first patch adds support in the Address Translation Library to invoke
the appropriate PRM handler to perform the translation.
The second patch leverages the support added in the first patch to log
DRAM Address and export it through the RAS tracepoint on occurrence of a
DRAM ECC error.
Changes in v2:
- Modify commit messages per feedback received.
- Remove unnecessary variables.
- Rename struct dram_addr to atl_dram_addr.
- Replace sprintf call in __log_ecc_error() with scnprintf.
- Pass the DRAM Address to edac_mc_handle_error() through "other_detail"
parameter instead of "msg".
Avadhut Naik (2):
RAS/AMD/ATL: Translate UMC normalized address to DRAM address using
PRM
EDAC/amd64: Incorporate DRAM Address in EDAC message
drivers/edac/amd64_edac.c | 23 +++++++++++++++++++++-
drivers/edac/amd64_edac.h | 1 +
drivers/ras/amd/atl/core.c | 3 ++-
drivers/ras/amd/atl/internal.h | 9 +++++++++
drivers/ras/amd/atl/prm.c | 36 ++++++++++++++++++++++++++++++----
drivers/ras/amd/atl/umc.c | 9 +++++++++
drivers/ras/ras.c | 18 +++++++++++++++--
include/linux/ras.h | 19 +++++++++++++++++-
8 files changed, 109 insertions(+), 9 deletions(-)
base-commit: 501973598d05fdb1d1089fbf3cf40b605b836e16
--
2.43.0
next reply other threads:[~2025-09-15 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 21:20 Avadhut Naik [this message]
2025-09-15 21:20 ` [PATCH v2 1/2] RAS/AMD/ATL: Translate UMC normalized address to DRAM address using PRM Avadhut Naik
2025-09-15 21:20 ` [PATCH v2 2/2] EDAC/amd64: Incorporate DRAM Address in EDAC message Avadhut Naik
2025-10-07 14:52 ` [PATCH v2 0/2] Incorporate DRAM address in EDAC messages Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915212244.886668-1-avadhut.naik@amd.com \
--to=avadhut.naik@amd.com \
--cc=avadnaik@amd.com \
--cc=bp@alien8.de \
--cc=john.allen@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®