mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kuen-Han Tsai <khtsai@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 David Brownell <dbrownell@users.sourceforge.net>,
	Nam Cao <namcao@linutronix.de>,
	 Zack Rusin <zack.rusin@broadcom.com>,
	 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Prashanth K <prashanth.k@oss.qualcomm.com>,
	 Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	John Keeping <jkeeping@inmusicbrands.com>,
	 Roy Luo <royluo@google.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Kuen-Han Tsai <khtsai@google.com>
Subject: [PATCH 2/6] usb: gadget: Introduce free_usb_request helper
Date: Tue, 16 Sep 2025 16:21:33 +0800	[thread overview]
Message-ID: <20250916-ready-v1-2-4997bf277548@google.com> (raw)
In-Reply-To: <20250916-ready-v1-0-4997bf277548@google.com>

Introduce the free_usb_request() function that frees both the request's
buffer and the request itself.

This function serves as the cleanup callback for DEFINE_FREE() to enable
automatic, scope-based cleanup for usb_request pointers.

Signed-off-by: Kuen-Han Tsai <khtsai@google.com>
---
 include/linux/usb/gadget.h | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
index 0f20794760887314d81a070755c8908c6ac4ed90..3aaf19e775580b19cbb2b30d8df8a282945edfa0 100644
--- a/include/linux/usb/gadget.h
+++ b/include/linux/usb/gadget.h
@@ -15,6 +15,7 @@
 #ifndef __LINUX_USB_GADGET_H
 #define __LINUX_USB_GADGET_H
 
+#include <linux/cleanup.h>
 #include <linux/configfs.h>
 #include <linux/device.h>
 #include <linux/errno.h>
@@ -293,6 +294,28 @@ static inline void usb_ep_fifo_flush(struct usb_ep *ep)
 
 /*-------------------------------------------------------------------------*/
 
+/**
+ * free_usb_request - frees a usb_request object and its buffer
+ * @req: the request being freed
+ *
+ * This helper function frees both the request's buffer and the request object
+ * itself by calling usb_ep_free_request(). Its signature is designed to be used
+ * with DEFINE_FREE() to enable automatic, scope-based cleanup for usb_request
+ * pointers.
+ */
+static inline void free_usb_request(struct usb_request *req)
+{
+	if (!req)
+		return;
+
+	kfree(req->buf);
+	usb_ep_free_request(req->ep, req);
+}
+
+DEFINE_FREE(free_usb_request, struct usb_request *, free_usb_request(_T))
+
+/*-------------------------------------------------------------------------*/
+
 struct usb_dcd_config_params {
 	__u8  bU1devExitLat;	/* U1 Device exit Latency */
 #define USB_DEFAULT_U1_DEV_EXIT_LAT	0x01	/* Less then 1 microsec */

-- 
2.51.0.384.g4c02a37b29-goog


  parent reply	other threads:[~2025-09-16  8:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16  8:21 [PATCH 0/6] usb: gadget: Refactor function drivers to use __free() cleanup Kuen-Han Tsai
2025-09-16  8:21 ` [PATCH 1/6] usb: gadget: Store endpoint pointer in usb_request Kuen-Han Tsai
2025-09-16  8:21 ` Kuen-Han Tsai [this message]
2025-09-16  8:21 ` [PATCH 3/6] usb: gadget: f_ncm: Refactor bind path to use __free() Kuen-Han Tsai
2025-09-16  8:21 ` [PATCH 4/6] usb: gadget: f_acm: " Kuen-Han Tsai
2025-09-16  8:21 ` [PATCH 5/6] usb: gadget: f_ecm: " Kuen-Han Tsai
2025-09-16  8:21 ` [PATCH 6/6] usb: gadget: f_rndis: " Kuen-Han Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250916-ready-v1-2-4997bf277548@google.com \
    --to=khtsai@google.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jkeeping@inmusicbrands.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=namcao@linutronix.de \
    --cc=prashanth.k@oss.qualcomm.com \
    --cc=royluo@google.com \
    --cc=zack.rusin@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®