From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Marcos Paulo de Souza <mpdesouza@suse.com>
Cc: Petr Mladek <pmladek@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Jason Wessel <jason.wessel@windriver.com>,
Daniel Thompson <danielt@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org,
kgdb-bugreport@lists.sourceforge.net
Subject: Re: [PATCH v4 1/5] printk: nbcon: Export console_is_usable
Date: Wed, 17 Sep 2025 10:07:47 -0400 [thread overview]
Message-ID: <20250917-imaginary-vigorous-condor-fccdc1@lemur> (raw)
In-Reply-To: <dad15813cfdc3b7c77ba71266e38a137d0015bcd.camel@suse.com>
On Wed, Sep 17, 2025 at 09:21:48AM -0300, Marcos Paulo de Souza wrote:
> > Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
> > Reviewed-by: Petr Mladek <pmladek@suse.com>
> >
> > It means that Macros developed a patch and Petr reviewed it.
> > The patch was not longer modified.
That's not entirely correct. The signed-off trailer is used as the boundary
indicating who was the person responsible for collecting the trailers. When
the trailers are collected by the original author as part of their iteration
cycles, their signed-off-by trailer goes below any trailers they have
received.
When the trailers are collected by the maintainer, any trailers they retrieve
will go below the original author's S-o-b, but above their own.
> >
> > Note the Reviewed-by tag might be preserved even when Marcos
> > later did some cosmetic changes, e.g. fixed a typo, formatting,
> > or rebased.
>
> Got it. I used b4 prep --update-trailers, and it added the Reviewed-by
> before my Sign-off. But still, this patch didn't change since the last
> submission, so I thought that it would be ok.
That is the correct behaviour.
-K
next prev parent reply other threads:[~2025-09-17 14:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 11:20 [PATCH v4 0/5] Handle NBCON consoles on KDB Marcos Paulo de Souza
2025-09-15 11:20 ` [PATCH v4 1/5] printk: nbcon: Export console_is_usable Marcos Paulo de Souza
2025-09-17 8:57 ` Petr Mladek
2025-09-17 12:21 ` Marcos Paulo de Souza
2025-09-17 14:07 ` Konstantin Ryabitsev [this message]
2025-09-18 13:02 ` Petr Mladek
2025-09-15 11:20 ` [PATCH v4 2/5] printk: nbcon: Introduce KDB helpers Marcos Paulo de Souza
2025-09-17 11:16 ` Petr Mladek
2025-09-15 11:20 ` [PATCH v4 3/5] printk: nbcon: Allow KDB to acquire the NBCON context Marcos Paulo de Souza
2025-09-17 12:09 ` Petr Mladek
2025-09-15 11:20 ` [PATCH v4 4/5] printk: nbcon: Export nbcon_write_context_set_buf Marcos Paulo de Souza
2025-09-17 12:18 ` Petr Mladek
2025-09-15 11:20 ` [PATCH v4 5/5] kdb: Adapt kdb_msg_write to work with NBCON consoles Marcos Paulo de Souza
2025-09-17 13:18 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917-imaginary-vigorous-condor-fccdc1@lemur \
--to=konstantin@linuxfoundation.org \
--cc=danielt@kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason.wessel@windriver.com \
--cc=john.ogness@linutronix.de \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mpdesouza@suse.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®