From: Borislav Petkov <bp@alien8.de>
To: Alexey Kardashevskiy <aik@amd.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
David Woodhouse <dwmw@amazon.co.uk>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Santosh Shukla <santosh.shukla@amd.com>,
"Nikunj A. Dadhania" <nikunj@amd.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [RFC PATCH] PCI: Add quirk to always map ivshmem as write-back
Date: Wed, 17 Sep 2025 20:38:21 +0200 [thread overview]
Message-ID: <20250917183821.GDaMsAHa7kVPBt5HAV@fat_crate.local> (raw)
In-Reply-To: <c6e09d1e-c950-4ba7-8773-2062e0c62068@amd.com>
On Mon, Sep 15, 2025 at 05:43:33PM +1000, Alexey Kardashevskiy wrote:
> yeah, sadly, there is one - people are actually using it, for, like,
> a decade, and not exactly keen on changing those user space tools :) Hence
> "RFC".
Then this commit message needs a lot more explanation as it is something the
kernel should support apparently when running as a guest...
But then, if it has been used for a decade already, why do you need that quirk
now? No one has noticed in 10 years time...?
> > > else
> > > + else if (!(pci_resource_flags(pdev, bar) & IORESOURCE_CACHEABLE))
> > ^^^^^^
> >
> > This can't build.
>
> Why? Compiles and works just fine.
Here's a more detailed explanation:
https://lore.kernel.org/r/202506131608.QlkxUPnI-lkp@intel.com
You haven't replaced the "else" with "else if" but left it there.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2025-09-17 18:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 8:22 Alexey Kardashevskiy
2025-06-12 8:27 ` Alexey Kardashevskiy
2025-06-24 1:42 ` Alexey Kardashevskiy
2025-06-25 16:28 ` Manivannan Sadhasivam
2025-07-18 1:58 ` Alexey Kardashevskiy
2025-09-12 16:49 ` Borislav Petkov
2025-09-15 7:43 ` Alexey Kardashevskiy
2025-09-17 18:38 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917183821.GDaMsAHa7kVPBt5HAV@fat_crate.local \
--to=bp@alien8.de \
--cc=aik@amd.com \
--cc=bhelgaas@google.com \
--cc=dwmw@amazon.co.uk \
--cc=kai.heng.feng@canonical.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=santosh.shukla@amd.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®