From: Peng Fan <peng.fan@nxp.com>
To: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Frank Li <frank.li@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>
Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 3/5] remoteproc: imx_rproc: Enable PM runtime support unconditionally
Date: Thu, 18 Sep 2025 19:51:18 +0800 [thread overview]
Message-ID: <20250918-imx_rproc_c2-v1-3-deec8183185f@nxp.com> (raw)
In-Reply-To: <20250918-imx_rproc_c2-v1-0-deec8183185f@nxp.com>
PM runtime support is safe and applicable across all i.MX platforms, not
just those using the SCU API. Remove the conditional check and enable PM
runtime unconditionally to simplify the code and ensure consistent power
management behavior.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/remoteproc/imx_rproc.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 74c958d44611b66e024180d69d71daac5a2f9e76..69b57cb4b251d9fb65a23e139a1960bf29c175ed 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -1123,19 +1123,17 @@ static int imx_rproc_probe(struct platform_device *pdev)
return dev_err_probe(dev, ret, "register restart handler failure\n");
}
- if (dcfg->method == IMX_RPROC_SCU_API) {
- ret = devm_pm_runtime_enable(dev);
- if (ret)
- return dev_err_probe(dev, ret, "Failed to enable runtime PM\n");
+ ret = devm_pm_runtime_enable(dev);
+ if (ret)
+ return dev_err_probe(dev, ret, "Failed to enable runtime PM\n");
- ret = pm_runtime_resume_and_get(dev);
- if (ret)
- return dev_err_probe(dev, ret, "pm_runtime get failed\n");
+ ret = pm_runtime_resume_and_get(dev);
+ if (ret)
+ return dev_err_probe(dev, ret, "pm_runtime get failed\n");
- ret = devm_add_action_or_reset(dev, imx_rproc_pm_runtime_put, dev);
- if (ret)
- return dev_err_probe(dev, ret, "Failed to add devm disable pm action\n");
- }
+ ret = devm_add_action_or_reset(dev, imx_rproc_pm_runtime_put, dev);
+ if (ret)
+ return dev_err_probe(dev, ret, "Failed to add devm disable pm action\n");
ret = devm_rproc_add(dev, rproc);
if (ret)
--
2.37.1
next prev parent reply other threads:[~2025-09-18 11:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 11:51 [PATCH 0/5] remoteproc: imx_rproc: misc clean up Peng Fan
2025-09-18 11:51 ` [PATCH 1/5] remoteproc: imx_rproc: Simplify clock enable logic using dcfg flags Peng Fan
2025-09-18 12:32 ` Daniel Baluta
2025-09-19 2:02 ` Peng Fan
2025-09-19 8:25 ` Daniel Baluta
2025-09-18 16:38 ` Frank Li
2025-09-18 11:51 ` [PATCH 2/5] remoteproc: imx_rproc: Make detach operation platform-specific Peng Fan
2025-09-18 12:36 ` Daniel Baluta
2025-09-18 16:39 ` Frank Li
2025-09-18 11:51 ` Peng Fan [this message]
2025-09-18 12:37 ` [PATCH 3/5] remoteproc: imx_rproc: Enable PM runtime support unconditionally Daniel Baluta
2025-09-18 16:40 ` Frank Li
2025-09-18 11:51 ` [PATCH 4/5] remoteproc: imx_rproc: Remove the assignement to method Peng Fan
2025-09-19 11:26 ` Daniel Baluta
2025-09-19 14:52 ` Frank Li
2025-09-18 11:51 ` [PATCH 5/5] MAINTAINERS: Add an entry for i.MX remoteproc driver Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250918-imx_rproc_c2-v1-3-deec8183185f@nxp.com \
--to=peng.fan@nxp.com \
--cc=andersson@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®