From: Cryolitia PukNgae via B4 Relay <devnull+cryolitia.uniontech.com@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
niecheng1@uniontech.com, zhanjun@uniontech.com,
Chenx Dust <chenx_dust@outlook.com>,
Cryolitia PukNgae <cryolitia@uniontech.com>
Subject: [PATCH] hwmon: (gpd-fan) Fix range check for pwm input
Date: Fri, 19 Sep 2025 16:38:49 +0800 [thread overview]
Message-ID: <20250919-hwmon-v1-1-2b69c8b9c062@uniontech.com> (raw)
From: Cryolitia PukNgae <cryolitia@uniontech.com>
Fixed the maximum value in the PWM input range check, allowing the
input to be set to 255.
Fixes: 0ab88e239439 ("hwmon: add GPD devices sensor driver")
Reported-by: Chenx Dust <chenx_dust@outlook.com>
Link: https://github.com/Cryolitia/gpd-fan-driver/pull/18
Co-developed-by: Chenx Dust <chenx_dust@outlook.com>
Signed-off-by: Chenx Dust <chenx_dust@outlook.com>
Signed-off-by: Cryolitia PukNgae <cryolitia@uniontech.com>
---
drivers/hwmon/gpd-fan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/gpd-fan.c b/drivers/hwmon/gpd-fan.c
index e0b3b46e1bf12a10097600f857c627a766f61a27..644dc3ca9df7da0174e513c47a820a6ff39eb0ef 100644
--- a/drivers/hwmon/gpd-fan.c
+++ b/drivers/hwmon/gpd-fan.c
@@ -571,7 +571,7 @@ static int gpd_fan_hwmon_write(__always_unused struct device *dev,
ret = 0;
goto OUT;
case hwmon_pwm_input:
- if (!in_range(val, 0, 255)) {
+ if (!in_range(val, 0, 256)) {
ret = -ERANGE;
goto OUT;
}
---
base-commit: 80038a758b7fc0cdb6987532cbbf3f75b13e0826
change-id: 20250919-hwmon-9703a3da195a
Best regards,
--
Cryolitia PukNgae <cryolitia@uniontech.com>
next reply other threads:[~2025-09-19 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 8:38 Cryolitia PukNgae via B4 Relay [this message]
2025-09-24 14:38 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250919-hwmon-v1-1-2b69c8b9c062@uniontech.com \
--to=devnull+cryolitia.uniontech.com@kernel.org \
--cc=chenx_dust@outlook.com \
--cc=cryolitia@uniontech.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=niecheng1@uniontech.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®