From: Steven Rostedt <rostedt@kernel.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
bpf@vger.kernel.org, Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrii Nakryiko <andrii@kernel.org>,
Indu Bhagat <indu.bhagat@oracle.com>,
"Jose E. Marchesi" <jemarch@gnu.org>,
Beau Belgrave <beaub@linux.microsoft.com>,
Jens Remus <jremus@linux.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>, Florian Weimer <fweimer@redhat.com>,
Sam James <sam@gentoo.org>,
"Paul E. McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH v16 09/10] unwind deferred: Use SRCU unwind_deferred_task_work()
Date: Sun, 21 Sep 2025 19:35:54 -0400 [thread overview]
Message-ID: <20250921193527.4fef26ec@batman.local.home> (raw)
In-Reply-To: <cic4dekp3h5fduzsar5lydynzambabar26zjzogdbn26dxiabh@g2eaji3bqlct>
On Fri, 19 Sep 2025 17:31:15 -0700
Josh Poimboeuf <jpoimboe@kernel.org> wrote:
> On Tue, Jul 29, 2025 at 02:23:13PM -0400, Steven Rostedt wrote:
> > @@ -230,6 +232,14 @@ int unwind_deferred_request(struct unwind_work *work, u64 *cookie)
> > if (WARN_ON_ONCE(!CAN_USE_IN_NMI && in_nmi()))
> > return -EINVAL;
> >
> > + /* Do not allow cancelled works to request again */
> > + bit = READ_ONCE(work->bit);
> > + if (WARN_ON_ONCE(bit < 0))
> > + return -EINVAL;
>
> The local 'bit' variable is unsigned long, so this will never be < 0.
>
> Should be "bit == -1"?
>
Yeah, that needs to be fixed. Thanks!
-- Steve
next prev parent reply other threads:[~2025-09-21 23:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 18:23 [PATCH v16 00/10] unwind_user: Deferred unwinding infrastructure Steven Rostedt
2025-07-29 18:23 ` [PATCH v16 01/10] unwind_user: Add user space unwinding API with frame pointer support Steven Rostedt
2025-07-29 18:23 ` [PATCH v16 02/10] unwind_user/deferred: Add unwind_user_faultable() Steven Rostedt
2025-07-29 18:23 ` [PATCH v16 03/10] unwind_user/deferred: Add unwind cache Steven Rostedt
2025-07-30 4:55 ` Indu Bhagat
2025-07-30 13:32 ` Steven Rostedt
2025-07-30 23:58 ` Indu Bhagat
2025-07-29 18:23 ` [PATCH v16 04/10] unwind_user/deferred: Add deferred unwinding interface Steven Rostedt
2025-07-29 18:23 ` [PATCH v16 05/10] unwind_user/deferred: Make unwind deferral requests NMI-safe Steven Rostedt
2025-07-29 18:23 ` [PATCH v16 06/10] unwind deferred: Use bitmask to determine which callbacks to call Steven Rostedt
2025-09-20 1:00 ` Josh Poimboeuf
2025-09-21 23:47 ` Steven Rostedt
2025-07-29 18:23 ` [PATCH v16 07/10] unwind deferred: Add unwind_completed mask to stop spurious callbacks Steven Rostedt
2025-07-29 18:23 ` [PATCH v16 08/10] unwind: Add USED bit to only have one conditional on way back to user space Steven Rostedt
2025-07-29 18:23 ` [PATCH v16 09/10] unwind deferred: Use SRCU unwind_deferred_task_work() Steven Rostedt
2025-08-01 0:29 ` Paul E. McKenney
2025-08-01 1:11 ` Steven Rostedt
2025-09-20 0:31 ` Josh Poimboeuf
2025-09-21 23:35 ` Steven Rostedt [this message]
2025-07-29 18:23 ` [PATCH v16 10/10] unwind: Finish up unwind when a task exits Steven Rostedt
2025-08-02 0:14 ` [PATCH v16 00/10] unwind_user: Deferred unwinding infrastructure patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250921193527.4fef26ec@batman.local.home \
--to=rostedt@kernel.org \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=axboe@kernel.dk \
--cc=beaub@linux.microsoft.com \
--cc=bpf@vger.kernel.org \
--cc=fweimer@redhat.com \
--cc=indu.bhagat@oracle.com \
--cc=jemarch@gnu.org \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=jremus@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=sam@gentoo.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®