From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A86462DC340; Mon, 22 Sep 2025 03:22:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758511332; cv=none; b=LgnXImqIlIDXn3DCbJXvSPV+pDIu6bNr+GBdB7NGx/BgWugKRkUrjB+Knqx6zYDPsIEBPoqvP+28pLHaML9/AFuHmxvr47zvBT3Q6H+z27ij8J1DgNiJqMJpipi2Vd4VVFFQnJn112te34YcP8wk8+GIYzzgI5KZg6wt3HwClWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758511332; c=relaxed/simple; bh=VHDdLDkLeO1KOC3C0gHzNdGVM+/XbRNsbPh7C6mdBSA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I6Ap6+OcthwYTDqPzEwjH+a1pxor2bT0+BI9SVmXOul3Z8fUSGOBfGaFEeBEOEUlgwixSPCcxFYejZDu2fNJMtH8sddJm5lDehK+B5Pj5SqS6ymdtTh81lm5JnaAGcAnHHKbs0HPDI/LiAoHAQcFj0dgYJd5C4Xj9sIGjqm04CE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org; spf=pass smtp.mailfrom=gentoo.org; arc=none smtp.client-ip=140.211.166.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gentoo.org Received: from localhost (unknown [180.158.240.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id B70E6341002; Mon, 22 Sep 2025 03:22:08 +0000 (UTC) Date: Mon, 22 Sep 2025 11:21:58 +0800 From: Yixun Lan To: Aurelien Jarno Cc: linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:RISC-V ARCHITECTURE" , "open list:RISC-V SPACEMIT SoC Support" Subject: Re: [PATCH 2/3] riscv: dts: spacemit: add 24c02 eeprom on BPI-F3 Message-ID: <20250922032158-GYA1291757@gentoo.org> References: <20250921210237.943370-1-aurelien@aurel32.net> <20250921210237.943370-3-aurelien@aurel32.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250921210237.943370-3-aurelien@aurel32.net> Hi Aurelien, On 23:01 Sun 21 Sep , Aurelien Jarno wrote: > The BPI-F3 contains a 24c02 eeprom, that contains among other things the > MAC addresses of the two network interfaces. For this reason, mark it as > read-only. > > Signed-off-by: Aurelien Jarno > --- > arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts > index 3b6e4f52e9aad..574d10fdf9b82 100644 > --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts > +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts > @@ -115,6 +115,15 @@ &i2c2 { > pinctrl-0 = <&i2c2_0_cfg>; > pinctrl-names = "default"; > status = "okay"; > + > + eeprom@50 { > + compatible = "atmel,24c02"; > + reg = <0x50>; > + vcc-supply = <&vcc1v8_sys>; > + pagesize = <16>; .. > + read-only; so you're sure there is no demand to write data to eeprom? (update info at linux env) > + size = <256>; > + }; > }; > > &i2c8 { > @@ -143,7 +152,7 @@ buck2 { > regulator-always-on; > }; > > - buck3 { > + vcc1v8_sys: buck3 { I'm not sure if adding an alias here is a good idea, it occurs buck3 serve the suppy for many devices, besides, to me it's more proper to name it as eeprom_vcc1v8 for the eeprom according to schematics in this case.. > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1800000>; > regulator-ramp-delay = <5000>; > -- > 2.47.2 > -- Yixun Lan (dlan)