From: rajasimandalos@gmail.com
To: linux-cifs@vger.kernel.org
Cc: sfrench@samba.org, pc@manguebit.org, ronniesahlberg@gmail.com,
sprasad@microsoft.com, tom@talpey.com, bharathsm@microsoft.com,
linux-kernel@vger.kernel.org,
Rajasi Mandal <rajasimandal@microsoft.com>
Subject: [PATCH 1/2] cifs: client: force multichannel=off when max_channels=1
Date: Mon, 22 Sep 2025 08:24:16 +0000 [thread overview]
Message-ID: <20250922082417.816331-1-rajasimandalos@gmail.com> (raw)
From: Rajasi Mandal <rajasimandal@microsoft.com>
Previously, specifying both multichannel and max_channels=1 as mount
options would leave multichannel enabled, even though it is not
meaningful when only one channel is allowed. This led to confusion and
inconsistent behavior, as the client would advertise multichannel
capability but never establish secondary channels.
Fix this by forcing multichannel to false whenever max_channels=1,
ensuring the mount configuration is consistent and matches user intent.
This prevents the client from advertising or attempting multichannel
support when it is not possible.
Signed-off-by: Rajasi Mandal <rajasimandal@microsoft.com>
---
fs/smb/client/fs_context.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c
index 072383899e81..43552b44f613 100644
--- a/fs/smb/client/fs_context.c
+++ b/fs/smb/client/fs_context.c
@@ -1820,6 +1820,13 @@ static int smb3_fs_context_parse_param(struct fs_context *fc,
goto cifs_parse_mount_err;
}
+ /*
+ * Multichannel is not meaningful if max_channels is 1.
+ * Force multichannel to false to ensure consistent configuration.
+ */
+ if (ctx->multichannel && ctx->max_channels == 1)
+ ctx->multichannel = false;
+
return 0;
cifs_parse_mount_err:
--
2.43.0
next reply other threads:[~2025-09-22 8:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 8:24 rajasimandalos [this message]
2025-09-22 8:24 ` [PATCH 2/2] cifs: client: allow changing multichannel mount options on remount rajasimandalos
2025-09-22 15:12 ` Enzo Matsumiya
2025-09-23 6:04 ` Shyam Prasad N
[not found] ` <CAEY6_V3RanNnjd=QkaZO=QoLLfiOhRGg7cCxHe2xGB1A05hEhQ@mail.gmail.com>
2025-09-23 17:32 ` Enzo Matsumiya
[not found] ` <CAH2r5msS2hrFOhjGddNUrAU3ZTSPyVwLv8w5c39cNKeH2MdgqA@mail.gmail.com>
2025-09-23 18:01 ` Enzo Matsumiya
[not found] ` <CAH2r5ms3W5S5tozMAk2NUj6tBEb=OCFK=OTO+TcYrmu_vncGTw@mail.gmail.com>
2025-09-23 18:12 ` Enzo Matsumiya
2025-09-22 21:11 ` Henrique Carvalho
2025-09-23 6:12 ` Shyam Prasad N
2025-09-23 14:21 ` Enzo Matsumiya
2025-09-22 14:41 ` [PATCH 1/2] cifs: client: force multichannel=off when max_channels=1 Henrique Carvalho
2025-09-22 14:59 ` Enzo Matsumiya
2025-09-22 16:14 ` Steve French
2025-09-22 17:15 ` Henrique Carvalho
2025-09-22 18:52 ` Enzo Matsumiya
2025-09-22 19:21 ` Henrique Carvalho
2025-09-23 5:38 ` Shyam Prasad N
2025-09-23 14:12 ` Enzo Matsumiya
2025-09-22 15:48 ` Steve French
2025-09-23 5:50 ` Shyam Prasad N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922082417.816331-1-rajasimandalos@gmail.com \
--to=rajasimandalos@gmail.com \
--cc=bharathsm@microsoft.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=rajasimandal@microsoft.com \
--cc=ronniesahlberg@gmail.com \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®