From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 4B8EF267AF1
	for <linux-kernel@vger.kernel.org>; Mon, 22 Sep 2025 08:46:15 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1758530778; cv=none; b=MqQx44PfHfNLHsEqgOmVcxsPwX/1EpiNtoemarOpurihW79Glcoj9eqjQuB1IRAPASh0i9gV3+Xf1NNI0nwdLx6rHG379Km57OOjLMlU5WCeBzdglN5WIFa8MvMUzjO6nmgI/Mf+Fj1KpbnvbBdFZjk3hVHAPO3aKbQywaDIhf0=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1758530778; c=relaxed/simple;
	bh=Pub+OSBTMDytwpa6RHo0/ei9pZRIabkn49M6T4D51WY=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=IG1i4wSfmVUgDxC2t79yjUosB282n239ejk1C+xVofAnXEWaEk3GXBOTL0E5SMLZaiFoenMnmNxjDLrl7a1MdgLmzHEP1+OhHbrFy6XrN1YHbr6hE8GnizWN+oQyN15irr1P6wufnFHbCIPscF4MNtndSKPWCdFrC340Kdpopc8=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 19D0D150C;
	Mon, 22 Sep 2025 01:46:07 -0700 (PDT)
Received: from localhost (e132581.arm.com [10.1.196.87])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E14303F66E;
	Mon, 22 Sep 2025 01:46:14 -0700 (PDT)
Date: Mon, 22 Sep 2025 09:46:13 +0100
From: Leo Yan <leo.yan@arm.com>
To: Jie Gan <jie.gan@oss.qualcomm.com>
Cc: Carl Worth <carl@os.amperecomputing.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	James Clark <james.clark@linaro.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 3/3] coresight: change the sink_ops to accept
 coresight_path
Message-ID: <20250922084613.GD516577@e132581.arm.com>
References: <20250922-fix_helper_data-v1-0-905e8115a24e@oss.qualcomm.com>
 <20250922-fix_helper_data-v1-3-905e8115a24e@oss.qualcomm.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20250922-fix_helper_data-v1-3-905e8115a24e@oss.qualcomm.com>

On Mon, Sep 22, 2025 at 03:31:41PM +0800, Jie Gan wrote:
> Update the sink_enable functions to accept coresight_path instead of
> a generic void *data, as coresight_path encapsulates all the necessary
> data required by devices along the path.
> 
> Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>

Good refactoring for me, thanks!

Reviewed-by: Leo Yan <leo.yan@arm.com>