From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66FA8223DFD for ; Tue, 23 Sep 2025 03:07:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758596853; cv=none; b=XYAGgBk6RJAw7o3sL0lttxF5DkhBnROPzE9SqqYZUyTCvX+Yyc2pLmpHzIeMDRiVct//RAmVCAGdMhdfkfNoqCjn7W74ng4pDm+h+QmRWL/5CsTBqNKF2aiatax8/eKzTKX8iF5keRBd/UXMW2Q3UVewhfDWy7igfUVw0Fuum6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758596853; c=relaxed/simple; bh=86Xxar4vRcinCahBFuQlLC0lBKykHJS+rMOTXHO6mII=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=mv230VB3e4kRivN9I+H3myU+TraMZPFFOFiWfpPsm4KF/argysia0bXOqRdtTp+0EdR3ooURHOtEnJ1gkw9x4d4COylzAj45FAinahyb6W+3IdqzqE+ilcepO846JhWTkR1s5uwfebNZv2t3efwbbN5pOFcUobvtkDPHM4QZovA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=FCLFePm9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="FCLFePm9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C9E6C4CEF0; Tue, 23 Sep 2025 03:07:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1758596852; bh=86Xxar4vRcinCahBFuQlLC0lBKykHJS+rMOTXHO6mII=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FCLFePm9McSbrWerrTzJUCkPyWJ2VBkWUJWJn5AUvV0L7dPAgosiGJJ9HOUcqRNjV hSsx0IzVlc77xyTJjUFjjJv/LUVymKA2lgYBpn/U+521SM2afv4V3a9wrkFfrLU0vL 2n3t9qAGri3DBNxsTEkbbNmzNZ/D8B89udzneY8o= Date: Mon, 22 Sep 2025 20:07:32 -0700 From: Andrew Morton To: Baoquan He Cc: "Bouron, Justinien" , "Rafael J . Wysocki" , Petr Mladek , Mario Limonciello , Marcos Paulo de Souza , "Graf (AWS), Alexander" , Steven Chen , Yan Zhao , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Kudrjavets, Gunnar" Subject: Re: [PATCH] kexec_core: Remove superfluous page offset handling in segment loading Message-Id: <20250922200732.f5c68c706e495635b1536ac2@linux-foundation.org> In-Reply-To: References: <20250910163116.49148-1-jbouron@amazon.com> <1659446A-F17C-4FF2-BE1B-3EC37520DDCB@amazon.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 12 Sep 2025 14:11:04 +0800 Baoquan He wrote: > > int sanity_check_segment_list(struct kimage *image) > > { > > // ... > > for (i = 0; i < nr_segments; i++) { > > unsigned long mstart, mend; > > > > mstart = image->segment[i].mem; > > mend = mstart + image->segment[i].memsz; > > if (mstart > mend) > > return -EADDRNOTAVAIL; > > if ((mstart & ~PAGE_MASK) || (mend & ~PAGE_MASK)) > > return -EADDRNOTAVAIL; > > if (mend >= KEXEC_DESTINATION_MEMORY_LIMIT) > > return -EADDRNOTAVAIL; > > } > > // ... > > } > > > > > That better be explained in log. > > Does it warrant a second revision to change the log? > > I would appreciate it if we can tell the reason a little bit in patch > log. Because we have codes as below where people assign a non PAGE_SIZE > to kbuf.buf_align. With a general conclusion, people need explore code > to find out. At least that's what I do when I check this patch. > > arch/x86/kernel/kexec-bzimage64.c: > static void *bzImage64_load(struct kimage *image, char *kernel, > unsigned long kernel_len, char *initrd, > unsigned long initrd_len, char *cmdline, > unsigned long cmdline_len) > { I'll drop this patch. Justinien, please send along an updated version for the next -rc cycle, thanks.