From: Utkarsh Singh <utkarsh.singh.em@gmail.com>
To: agruenba@redhat.com
Cc: david.hunter.linux@gmail.com, gfs2@lists.linux.dev,
linux-kernel@vger.kernel.org, rpeterso@redhat.com,
skhan@linuxfoundation.org, utkarsh.singh.em@gmail.com
Subject: Re: [PATCH v2] gfs2/sysfs: Replace sprintf/snprintf with sysfs_emit()
Date: Wed, 24 Sep 2025 00:48:57 +0530 [thread overview]
Message-ID: <20250923191900.77568-1-utkarsh.singh.em@gmail.com> (raw)
In-Reply-To: <CAHc6FU5C3n2wyO91gcDVLGr643d1Y5e4xPmM1d9rw18A=fod9g@mail.gmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 932 bytes --]
>> Documentation/filesystems/sysfs.rst mentions that show() should only
>> use sysfs_emit() or sysfs_emit_at() when formatting values returned
>> to user space. This patch updates the GFS2 sysfs interface accordingly.
>>
>> It replaces uses of sprintf() and snprintf() in all *_show() functions
>> with sysfs_emit() to align with current kernel sysfs API best practices.
>
>I've applied that part. I'm not pushing this into the upcoming merge
>window anymore, though.
>
Am I correct in understanding that these changes have already been applied?
If so, could you please advise where I might track them to avoid any
redundant work in the future?
>> It also updates the GFS2_SHOW_UINT macro to use sysfs_emit() instead
>> of snprintf().
>
>Huh, what's that?
>
Sorry for the confusion — that was meant to refer to the `TUNE_ATTR_2`
macro in fs/gfs2/sys.c, which defines the *_show functions for tuning
parameters.
Thanks,
Utkarsh
prev parent reply other threads:[~2025-09-23 19:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 17:52 Utkarsh Singh
2025-09-22 21:35 ` Andreas Gruenbacher
2025-09-23 19:18 ` Utkarsh Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250923191900.77568-1-utkarsh.singh.em@gmail.com \
--to=utkarsh.singh.em@gmail.com \
--cc=agruenba@redhat.com \
--cc=david.hunter.linux@gmail.com \
--cc=gfs2@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=rpeterso@redhat.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®