mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] clocksource/drivers/sh_cmt: Do not power down channels used for events
Date: Thu, 25 Sep 2025 07:12:19 +0200	[thread overview]
Message-ID: <20250925051219.GB1062104@ragnatech.se> (raw)
In-Reply-To: <CAMuHMdWt07VP=i_5S2bm6yaRwOovzc4hgZzYaYvpqj4nronxgA@mail.gmail.com>

On 2025-09-24 15:46:45 +0200, Geert Uytterhoeven wrote:
> Hi Daniel,
> 
> On Wed, 24 Sept 2025 at 15:43, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
> > On 24/09/2025 11:31, Niklas Söderlund wrote:
> > > If it's not too late I think we should drop it. The issue this work
> > > tries to solve is a lockdep blurb which highlights a design issue in the
> > > driver. But the driver have function properly in the past. So I think
> > > it's better I work on solving the blurb without any regressions.
> >
> > Ok, dropping 2/2 but keeping 1/2 is fine, right ?
> 
> 1/2 is a refactoring without any functional impact.
> Thanks!

Thanks to the both of you! Geert for testing and finding the regression 
and Daniel for his quick action removing it from the pull request. I 
will work on a v3 which tries to solve the original issue without the 
regression.

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
Kind Regards,
Niklas Söderlund

  reply	other threads:[~2025-09-25  5:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-10 14:26 [PATCH v2 0/2] clocksource/drivers/sh_cmt: Improve clock event design Niklas Söderlund
2025-09-10 14:26 ` [PATCH v2 1/2] clocksource/drivers/sh_cmt: Split start/stop of clock source and events Niklas Söderlund
2025-09-10 14:26 ` [PATCH v2 2/2] clocksource/drivers/sh_cmt: Do not power down channels used for events Niklas Söderlund
2025-09-23 14:56   ` Geert Uytterhoeven
2025-09-24  9:19     ` Daniel Lezcano
2025-09-24  9:31       ` Niklas Söderlund
2025-09-24 13:43         ` Daniel Lezcano
2025-09-24 13:46           ` Geert Uytterhoeven
2025-09-25  5:12             ` Niklas Söderlund [this message]
2025-09-17  9:02 ` [PATCH v2 0/2] clocksource/drivers/sh_cmt: Improve clock event design Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250925051219.GB1062104@ragnatech.se \
    --to=niklas.soderlund+renesas@ragnatech.se \
    --cc=daniel.lezcano@linaro.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®