From: Lee Jones <lee@kernel.org>
To: Qunqin Zhao <zhaoqunqin@loongson.cn>,
Yinggang Gu <guyinggang@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Nathan Chancellor <nathan@kernel.org>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko@kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: (subset) [PATCH] tpm: loongson: Add bufsiz parameter to tpm_loongson_send()
Date: Thu, 25 Sep 2025 12:47:14 +0100 [thread overview]
Message-ID: <20250925114714.GE8757@google.com> (raw)
In-Reply-To: <175880079495.625134.9934244689955652059.b4-ty@kernel.org>
On Thu, 25 Sep 2025, Lee Jones wrote:
> On Wed, 17 Sep 2025 10:09:00 -0700, Nathan Chancellor wrote:
> > Commit 5c83b07df9c5 ("tpm: Add a driver for Loongson TPM device") has a
> > semantic conflict with commit 07d8004d6fb9 ("tpm: add bufsiz parameter
> > in the .send callback"), as the former change was developed against a
> > tree without the latter change. This results in a build error:
> >
> > drivers/char/tpm/tpm_loongson.c:48:17: error: initialization of 'int (*)(struct tpm_chip *, u8 *, size_t, size_t)' {aka 'int (*)(struct tpm_chip *, unsigned char *, long unsigned int, long unsigned int)'} from incompatible pointer type 'int (*)(struct tpm_chip *, u8 *, size_t)' {aka 'int (*)(struct tpm_chip *, unsigned char *, long unsigned int)'} [-Wincompatible-pointer-types]
> > 48 | .send = tpm_loongson_send,
> > | ^~~~~~~~~~~~~~~~~
> > drivers/char/tpm/tpm_loongson.c:48:17: note: (near initialization for 'tpm_loongson_ops.send')
> > drivers/char/tpm/tpm_loongson.c:31:12: note: 'tpm_loongson_send' declared here
> > 31 | static int tpm_loongson_send(struct tpm_chip *chip, u8 *buf, size_t count)
> > | ^~~~~~~~~~~~~~~~~
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] tpm: loongson: Add bufsiz parameter to tpm_loongson_send()
> commit: 39377467669197b02479798f49e3f19344155dc9
Send for testing.
Will follow-up on the PR once complete.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2025-09-25 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 17:09 Nathan Chancellor
2025-09-18 1:50 ` Qunqin Zhao
2025-09-18 15:56 ` Jarkko Sakkinen
2025-09-18 15:57 ` Jarkko Sakkinen
2025-09-25 11:46 ` (subset) " Lee Jones
2025-09-25 11:47 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925114714.GE8757@google.com \
--to=lee@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=guyinggang@loongson.cn \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=peterhuewe@gmx.de \
--cc=zhaoqunqin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®