From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] firewire: core: revert "serialize topology building and bus manager work"
Date: Thu, 25 Sep 2025 22:53:49 +0900 [thread overview]
Message-ID: <20250925135349.GB329042@workstation.local> (raw)
In-Reply-To: <20250924131823.262136-1-o-takashi@sakamocchi.jp>
On Wed, Sep 24, 2025 at 10:18:21PM +0900, Takashi Sakamoto wrote:
> Hi,
>
> The patchset that serialized bm_work() and fw_core_handle_bus_reset()
> was merged without sufficient consideration of the race condition during
> fw_card removal.
>
> This patchset reverts some commits and restores the acquisition of the
> fw_card spin lock.
>
> [1] https://lore.kernel.org/lkml/20250917000347.52369-1-o-takashi@sakamocchi.jp/
>
> Changes from v1:
> * Fulfill cover-letter title
>
> Takashi Sakamoto (2):
> Revert "firewire: core: shrink critical section of fw_card spinlock in
> bm_work"
> Revert "firewire: core: disable bus management work temporarily during
> updating topology"
>
> drivers/firewire/core-card.c | 38 +++++++++++++++++++++++++-------
> drivers/firewire/core-topology.c | 8 -------
> 2 files changed, 30 insertions(+), 16 deletions(-)
Applied to for-next branch.
Regards
Takashi Sakamoto
prev parent reply other threads:[~2025-09-25 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 12:42 [PATCH 0/2] firewire: core: Takashi Sakamoto
2025-09-24 12:42 ` [PATCH 1/2] Revert "firewire: core: shrink critical section of fw_card spinlock in bm_work" Takashi Sakamoto
2025-09-24 12:42 ` [PATCH 2/2] Revert "firewire: core: disable bus management work temporarily during updating topology" Takashi Sakamoto
2025-09-24 13:18 ` [PATCH v2 0/2] firewire: core: revert "serialize topology building and bus manager work" Takashi Sakamoto
2025-09-24 13:18 ` [PATCH v2 1/2] Revert "firewire: core: shrink critical section of fw_card spinlock in bm_work" Takashi Sakamoto
2025-09-24 13:18 ` [PATCH v2 2/2] Revert "firewire: core: disable bus management work temporarily during updating topology" Takashi Sakamoto
2025-09-25 13:53 ` Takashi Sakamoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925135349.GB329042@workstation.local \
--to=o-takashi@sakamocchi.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®