From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E07D92EC08C for ; Thu, 25 Sep 2025 16:04:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758816284; cv=none; b=jAj3khOMjvofIiaUIJhdDBmuZC332YoMy92NBAMmQI5N3XoQpI/xwR2ic17BswUIORiEPA3TR9WwHR6SJATVOGMW4C8KzJzGjJUHfrQrI2N6sUx++SYHWhuId3BPkjfNm3PVl201i/LAOzHx9s+4N+hoN4wwdOWfCJfA4Oum154= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758816284; c=relaxed/simple; bh=7KIMIrwdi4UhSiEDt+IdaPb2j2bnoGnX++P/yjvjKFs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q8VgyRkCK2oRFHvFmCHln9zGhbl0hrhri8yOH2OxG1EGdn8zdI6mu77qLFDk1ysoZZnzgefAOYOc06sdbGhn6/j2jAJAWa+exDIm49yoZYQknk50Gr5LpSE5LaW0vvHCGgoZywX3Q6Rry8ClDA7JLFrTUN1oECyIIVC4sBBwL6M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 19AA31692; Thu, 25 Sep 2025 09:04:34 -0700 (PDT) Received: from localhost (e132581.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C45EE3F694; Thu, 25 Sep 2025 09:04:41 -0700 (PDT) Date: Thu, 25 Sep 2025 17:04:40 +0100 From: Leo Yan To: James Clark Cc: Suzuki K Poulose , Mike Leach , Jie Gan , Carl Worth , Alexander Shishkin , Tingwei Zhang , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 1/3] coresight: tmc: add the handle of the event to the path Message-ID: <20250925160440.GD7985@e132581.arm.com> References: <20250922-fix_helper_data-v1-0-905e8115a24e@oss.qualcomm.com> <20250922-fix_helper_data-v1-1-905e8115a24e@oss.qualcomm.com> <874isuo0m2.fsf@rasp.cworth.amperemail.amperecomputing.com> <3b16607f-8995-46b1-aecf-c6aa79f66f9d@arm.com> <635ba698-d7a9-40d0-9285-4ec108d4a536@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <635ba698-d7a9-40d0-9285-4ec108d4a536@linaro.org> On Thu, Sep 25, 2025 at 11:10:51AM +0100, James Clark wrote: > > > I would suggest in the csdev (coresight_device) structure itself. We > > > already have some sink specific data in here e.g. perf_sink_id_map. [...] > > I think this data is specific to the session we are enabling the > > device(s) in. e.g., we keep the trace-id in the path. > > So, I don't mind having this in the path structure. > > Instead of modifying csdev with additional locking from "etm-perf" > > it is always cleaner to handle this in the path. > > Yeah, and perf_sink_id_map only "needs" to be in the csdev because it > controls sharing IDs between multiple paths which can't be accomplished by > storing it in the path. This is a bit off-topic: do we really need to maintain an id_map in every sink device, or could we simply use a global id_map? I might miss some info; anyway, consolidating trace IDs is a low priority for me and not critical to this thread. But this might be benefit for later refactoring. Thanks, Leo