From: Peng Fan <peng.fan@oss.nxp.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Peng Fan <peng.fan@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Hiago De Franco <hiago.franco@toradex.com>,
linux-remoteproc@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Frank Li <Frank.Li@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>
Subject: Re: [PATCH v2 0/6] remoteproc: imx_rproc: Use device managed API to clean up the driver
Date: Fri, 26 Sep 2025 16:26:55 +0800 [thread overview]
Message-ID: <20250926082655.GE8204@nxa18884-linux.ap.freescale.net> (raw)
In-Reply-To: <aNVe6MG2HiWNJZQP@p14s>
On Thu, Sep 25, 2025 at 09:25:28AM -0600, Mathieu Poirier wrote:
>On Thu, Sep 25, 2025 at 04:31:15AM +0800, Peng Fan wrote:
>
>It is fortunate that time was taken to understand the problem and fix it
>correctly. Otherwise we'd still have a problem and more patches, possibly
>wrong as well, would have been needed.
Thanks for your caution and patience.
>
>> >
>
>Most people tend to address one problem at a time, especially when subsequent
>patchsets have dependencies on the previous ones. I'm not sure there is a need
>to document something like that.
I will not post dependent patches in future.
>
>> I ask because I have other patches queued that are independent of the current
>> series, such as:
>> - Reintroducing the table_sz clearing
>> - Misc cleanup in remoteproc core
>
>I'm fine with those, as long as you address just one proble at any given time.
Thanks. So multiple patchsets/patches from one developer are allowed only if
each patchset/patch focus on a specific area/problem and no dependency.
It is clear to me.
>
>>
>> I understand you may be busy and have limited bandwidth. Would it be feasible
>> to offload part of the review work to Bjorn? I rarely see Bjorn reviewing i.MX
>> patches. Alternatively, could we consider bringing in a third maintainer to
>> help accelerate the review process?
>>
>
>How fast do you want to go? By and large, I reply to patchsets within a week,
>sometimes two when things are busy. And when I can't meet those standards, I
>send out an email to the mailing list with the review order of the patches in
>my queue. What else are you expecting?
I have been blocked once [1], this make me delay about two months to post out
i.MX95 (: For i.MX95 reviewing cycle, it is not that smooth. Anyway, I get
lesson learned and will follow the rules.
More and more, we(NXP) are taking upstream first. And I have requested Daniel
and Frank(both are very experienced Linux Kernel developer) to help review, so
hope we could move a bit smoothly.
For now,
To imx_rproc.c, the queue:
cleanup patchset2(at here now), cleanup patchset3, i.MX95 support, i.MX943 support
To imx_dsp_rproc.c, the queue:
Drop method, switch to use ops
To remoteproc_core.c, the queue:
Introduce back clearing table_sz.
Use scoped API
Nothing special to expect from you. I get the message that non-relevant
patchsets could be posted out for reviewing, and one or two weeks is good for
me.
Appreciate for your time.
[1] https://lore.kernel.org/linux-remoteproc/CANLsYkyEhhQA5KOsNveGSHUc3ZpckoL-CCHNZ0DZLMNYdNGzdQ@mail.gmail.com/
Thanks,
Peng
prev parent reply other threads:[~2025-09-26 7:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 5:16 Peng Fan
2025-09-23 5:16 ` [PATCH v2 1/6] remoteproc: imx_rproc: Fix runtime PM cleanup order and error handling Peng Fan
2025-09-25 10:18 ` Ulf Hansson
2025-09-25 14:24 ` Peng Fan
2025-09-25 13:49 ` Ulf Hansson
2025-09-23 5:16 ` [PATCH v2 2/6] remoteproc: imx_rproc: Use devm_add_action_or_reset() for workqueue cleanup Peng Fan
2025-09-23 5:16 ` [PATCH v2 3/6] remoteproc: imx_rproc: Use devm_add_action_or_reset() for mailbox cleanup Peng Fan
2025-09-23 5:16 ` [PATCH v2 4/6] remoteproc: imx_rproc: Use devm_clk_get_enabled() and simplify cleanup Peng Fan
2025-09-23 5:16 ` [PATCH v2 5/6] remoteproc: imx_rproc: Use devm_add_action_or_reset() for scu cleanup Peng Fan
2025-09-23 5:16 ` [PATCH v2 6/6] remoteproc: imx_rproc: Use devm_rproc_add() helper Peng Fan
2025-09-24 16:46 ` [PATCH v2 0/6] remoteproc: imx_rproc: Use device managed API to clean up the driver Peng Fan
2025-09-24 17:10 ` Mathieu Poirier
2025-09-24 20:31 ` Peng Fan
2025-09-25 15:25 ` Mathieu Poirier
2025-09-26 8:26 ` Peng Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250926082655.GE8204@nxa18884-linux.ap.freescale.net \
--to=peng.fan@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=andersson@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=hiago.franco@toradex.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®