From: Jason Gunthorpe <jgg@nvidia.com>
To: Abhijit Gangurde <abhijit.gangurde@amd.com>
Cc: leon@kernel.org, allen.hubbe@amd.com, nikhil.agarwal@amd.com,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma-next 1/1] RDMA/ionic: Fix memory leak of admin q_wr
Date: Fri, 26 Sep 2025 13:15:45 -0300 [thread overview]
Message-ID: <20250926161545.GB2827732@nvidia.com> (raw)
In-Reply-To: <20250924142123.18344-1-abhijit.gangurde@amd.com>
On Wed, Sep 24, 2025 at 07:51:23PM +0530, Abhijit Gangurde wrote:
> The admin queue work request buffer, aq->q_wr, is allocated
> via kcalloc in __ionic_create_rdma_adminq. However, it was
> not being freed in the corresponding teardown function
> __ionic_destroy_rdma_adminq. This results in a memory leak.
> Fix this leak by adding the missing kfree(aq->q_wr) in the
> destruction path.
>
> Fixes: f3bdbd42702c ("RDMA/ionic: Create device queues to support admin operations")
> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
> ---
> drivers/infiniband/hw/ionic/ionic_admin.c | 1 +
> 1 file changed, 1 insertion(+)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2025-09-26 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 14:21 Abhijit Gangurde
2025-09-26 16:15 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250926161545.GB2827732@nvidia.com \
--to=jgg@nvidia.com \
--cc=abhijit.gangurde@amd.com \
--cc=allen.hubbe@amd.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nikhil.agarwal@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®