From: Sang-Heon Jeon <ekffu200098@gmail.com>
To: phillip@squashfs.org.uk
Cc: linux-kernel@vger.kernel.org,
Sang-Heon Jeon <ekffu200098@gmail.com>,
syzbot+f754e01116421e9754b9@syzkaller.appspotmail.com,
Amir Goldstein <amir73il@gmail.com>
Subject: [PATCH] squashfs: add sanity check for invalid inode size
Date: Sat, 27 Sep 2025 10:52:47 +0900 [thread overview]
Message-ID: <20250927015247.957452-1-ekffu200098@gmail.com> (raw)
Corrupted squashfs images can have negative inode sizes. Add sanity
check to prevent negative inode size.
Reported-by: syzbot+f754e01116421e9754b9@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=f754e01116421e9754b9
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
Tested-by: syzbot+f754e01116421e9754b9@syzkaller.appspotmail.com
Cc: Amir Goldstein <amir73il@gmail.com>
---
Special thanks to Amir's kindness analysis [1]. I couldn't find proper
tag for credit, so i just cc-ing. But feel free to add proper credit.
Also, I referred method of erofs. but i might be wrong, please let me
know about that. Thanks for consideration.
[1] https://lore.kernel.org/all/CAOQ4uxgkpi4v3NTSTq5GGJEceHHi97iY4rtsAJuo5c-yxu-Bzg@mail.gmail.com/
---
fs/squashfs/inode.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/fs/squashfs/inode.c b/fs/squashfs/inode.c
index ddc65d006063..148cd75f5bd7 100644
--- a/fs/squashfs/inode.c
+++ b/fs/squashfs/inode.c
@@ -426,6 +426,12 @@ int squashfs_read_inode(struct inode *inode, long long ino)
return -EINVAL;
}
+ if (unlikely(inode->i_size < 0)) {
+ ERROR("Negative i_size %lld inode 0x%llx\n",
+ inode->i_size, ino);
+ return -EINVAL;
+ }
+
if (xattr_id != SQUASHFS_INVALID_XATTR && msblk->xattr_id_table) {
err = squashfs_xattr_lookup(sb, xattr_id,
&squashfs_i(inode)->xattr_count,
--
2.43.0
reply other threads:[~2025-09-27 1:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250927015247.957452-1-ekffu200098@gmail.com \
--to=ekffu200098@gmail.com \
--cc=amir73il@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@squashfs.org.uk \
--cc=syzbot+f754e01116421e9754b9@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®