From: Yuri Andriaccio <yurand2000@gmail.com>
To: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Luca Abeni <luca.abeni@santannapisa.it>,
Yuri Andriaccio <yuri.andriaccio@santannapisa.it>
Subject: [RFC PATCH v3 15/24] sched/rt: Remove old RT_GROUP_SCHED data structures
Date: Mon, 29 Sep 2025 11:22:12 +0200 [thread overview]
Message-ID: <20250929092221.10947-16-yurand2000@gmail.com> (raw)
In-Reply-To: <20250929092221.10947-1-yurand2000@gmail.com>
From: luca abeni <luca.abeni@santannapisa.it>
Completely remove the old RT_GROUP_SCHED's functions and data structures.
Co-developed-by: Yuri Andriaccio <yurand2000@gmail.com>
Signed-off-by: Yuri Andriaccio <yurand2000@gmail.com>
Signed-off-by: luca abeni <luca.abeni@santannapisa.it>
---
include/linux/sched.h | 4 ----
kernel/sched/rt.c | 1 -
kernel/sched/sched.h | 26 --------------------------
3 files changed, 31 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 5022ff99c5d..379923eba59 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -624,13 +624,9 @@ struct sched_rt_entity {
unsigned short on_rq;
unsigned short on_list;
- struct sched_rt_entity *back;
#ifdef CONFIG_RT_GROUP_SCHED
- struct sched_rt_entity *parent;
/* rq on which this entity is (to be) queued: */
struct rt_rq *rt_rq;
- /* rq "owned" by this entity/group: */
- struct rt_rq *my_q;
#endif
} __randomize_layout;
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 94693093b70..1cdc699bbb7 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1,4 +1,3 @@
-#pragma GCC diagnostic ignored "-Wunused-function"
// SPDX-License-Identifier: GPL-2.0
/*
* Real-Time Scheduling Class (mapped to the SCHED_FIFO and SCHED_RR
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 97e1e779df9..fddb171145e 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -310,15 +310,6 @@ struct rt_prio_array {
struct list_head queue[MAX_RT_PRIO];
};
-struct rt_bandwidth {
- /* nests inside the rq lock: */
- raw_spinlock_t rt_runtime_lock;
- ktime_t rt_period;
- u64 rt_runtime;
- struct hrtimer rt_period_timer;
- unsigned int rt_period_active;
-};
-
struct dl_bandwidth {
raw_spinlock_t dl_runtime_lock;
u64 dl_runtime;
@@ -485,7 +476,6 @@ struct task_group {
struct sched_dl_entity **dl_se;
struct rt_rq **rt_rq;
- struct rt_bandwidth rt_bandwidth;
struct dl_bandwidth dl_bandwidth;
#endif
@@ -801,11 +791,6 @@ struct scx_rq {
};
#endif /* CONFIG_SCHED_CLASS_EXT */
-static inline int rt_bandwidth_enabled(void)
-{
- return 0;
-}
-
/* RT IPI pull logic requires IRQ_WORK */
#if defined(CONFIG_IRQ_WORK) && defined(CONFIG_SMP)
# define HAVE_RT_PUSH_IPI
@@ -823,17 +808,6 @@ struct rt_rq {
bool overloaded;
struct plist_head pushable_tasks;
- int rt_queued;
-
-#ifdef CONFIG_RT_GROUP_SCHED
- int rt_throttled;
- u64 rt_time; /* consumed RT time, goes up in update_curr_rt */
- u64 rt_runtime; /* allotted RT time, "slice" from rt_bandwidth, RT sharing/balancing */
- /* Nests inside the rq lock: */
- raw_spinlock_t rt_runtime_lock;
-
- unsigned int rt_nr_boosted;
-#endif
#ifdef CONFIG_CGROUP_SCHED
struct task_group *tg; /* this tg has "this" rt_rq on given CPU for runnable entities */
#endif
--
2.51.0
next prev parent reply other threads:[~2025-09-29 9:22 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 9:21 [RFC PATCH v3 00/24] Hierarchical Constant Bandwidth Server Yuri Andriaccio
2025-09-29 9:21 ` [RFC PATCH v3 01/24] sched/deadline: Do not access dl_se->rq directly Yuri Andriaccio
2025-10-02 13:10 ` Juri Lelli
2025-09-29 9:21 ` [RFC PATCH v3 02/24] sched/deadline: Distinct between dl_rq and my_q Yuri Andriaccio
2025-10-02 13:29 ` Juri Lelli
2025-09-29 9:22 ` [RFC PATCH v3 03/24] sched/rt: Pass an rt_rq instead of an rq where needed Yuri Andriaccio
2025-10-02 14:01 ` Juri Lelli
2025-09-29 9:22 ` [RFC PATCH v3 04/24] sched/rt: Move some functions from rt.c to sched.h Yuri Andriaccio
2025-10-02 14:12 ` Juri Lelli
2025-09-29 9:22 ` [RFC PATCH v3 05/24] sched/rt: Disable RT_GROUP_SCHED Yuri Andriaccio
2025-10-02 15:35 ` Juri Lelli
2025-09-29 9:22 ` [RFC PATCH v3 06/24] sched/rt: Introduce HCBS specific structs in task_group Yuri Andriaccio
2025-10-02 15:58 ` Juri Lelli
2025-09-29 9:22 ` [RFC PATCH v3 07/24] sched/core: Initialize root_task_group Yuri Andriaccio
2025-10-02 16:33 ` Juri Lelli
2025-09-29 9:22 ` [RFC PATCH v3 08/24] sched/deadline: Add dl_init_tg Yuri Andriaccio
2025-10-08 6:25 ` Juri Lelli
2025-09-29 9:22 ` [RFC PATCH v3 09/24] sched/rt: Add {alloc/free}_rt_sched_group Yuri Andriaccio
2025-10-08 7:28 ` Juri Lelli
2025-09-29 9:22 ` [RFC PATCH v3 10/24] sched/deadline: Account rt-cgroups bandwidth in deadline tasks schedulability tests Yuri Andriaccio
2025-09-29 9:22 ` [RFC PATCH v3 11/24] sched/rt: Add rt-cgroups' dl-servers operations Yuri Andriaccio
2025-10-08 10:26 ` Juri Lelli
2025-09-29 9:22 ` [RFC PATCH v3 12/24] sched/rt: Update task event callbacks for HCBS scheduling Yuri Andriaccio
2025-10-09 6:54 ` Juri Lelli
2025-09-29 9:22 ` [RFC PATCH v3 13/24] sched/rt: Update rt-cgroup schedulability checks Yuri Andriaccio
2025-09-29 11:03 ` Markus Elfring
2025-10-09 9:51 ` Juri Lelli
2025-09-29 9:22 ` [RFC PATCH v3 14/24] sched/rt: Allow zeroing the runtime of the root control group Yuri Andriaccio
2025-10-09 13:54 ` Juri Lelli
2025-09-29 9:22 ` Yuri Andriaccio [this message]
2025-09-29 9:22 ` [RFC PATCH v3 16/24] sched/core: Cgroup v2 support Yuri Andriaccio
2025-09-29 9:22 ` [RFC PATCH v3 17/24] sched/rt: Remove support for cgroups-v1 Yuri Andriaccio
2025-10-15 11:51 ` Juri Lelli
2025-09-29 9:22 ` [RFC PATCH v3 18/24] sched/deadline: Allow deeper hierarchies of RT cgroups Yuri Andriaccio
2025-10-15 14:24 ` Juri Lelli
2025-09-29 9:22 ` [RFC PATCH v3 19/24] sched/rt: Add rt-cgroup migration Yuri Andriaccio
2025-09-29 9:22 ` [RFC PATCH v3 20/24] sched/rt: Add HCBS migration related checks and function calls Yuri Andriaccio
2025-09-29 9:22 ` [RFC PATCH v3 21/24] sched/deadline: Make rt-cgroup's servers pull tasks on timer replenishment Yuri Andriaccio
2025-09-29 9:22 ` [RFC PATCH v3 22/24] sched/deadline: Fix HCBS migrations on server stop Yuri Andriaccio
2025-09-29 9:22 ` [RFC PATCH v3 23/24] sched/core: Execute enqueued balance callbacks when changing allowed CPUs Yuri Andriaccio
2025-09-29 9:22 ` [RFC PATCH v3 24/24] sched/core: Execute enqueued balance callbacks when migrating task betweeen cgroups Yuri Andriaccio
2025-10-02 9:00 ` [RFC PATCH v3 00/24] Hierarchical Constant Bandwidth Server Juri Lelli
2025-10-15 14:35 ` Juri Lelli
2025-10-15 15:17 ` Yuri Andriaccio
2025-10-20 9:40 ` Juri Lelli
2025-10-24 8:02 ` luca abeni
2025-11-03 10:32 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250929092221.10947-16-yurand2000@gmail.com \
--to=yurand2000@gmail.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yuri.andriaccio@santannapisa.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®